FIX: Gate translation to public posts or posts within a certain age #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
reviewed
May 27, 2025
tgxworld
reviewed
May 27, 2025
tgxworld
reviewed
May 27, 2025
tgxworld
reviewed
May 27, 2025
tgxworld
reviewed
May 27, 2025
| expect { job.execute({ post_id: post.id }) }.not_to raise_error | ||
| end | ||
|
|
||
| it "skips public content when configured" do |
Contributor
There was a problem hiding this comment.
Suggested change
| it "skips public content when configured" do | |
| it "skips public content when `automatic_translation_backfill_limit_to_public_content ` site setting is enabled" do |
Suggestion so that it is most specific as to what is configured.
tgxworld
approved these changes
May 27, 2025
Contributor
|
Approving first as the performance concern will be resolved before merging. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two existing site settings:
automatic_translation_backfill_limit_to_public_contentautomatic_translation_backfill_max_age_daysWe need to use them for
PostLocalization(& topic, cat) as well. They are used in the old feature forDiscourseTranslate::PostTranslation(& topic) @ #255.Also added
sidekiq_options retry: falsefor the jobs as they are non-critical.