DEV: Remove the anon language switcher and update settings #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
remove-anon-switcher
branch
from
4ce8d6f to
cbe7f73
Compare
xfalcox
approved these changes
May 28, 2025
nattsw
added a commit
to discourse/discourse
that referenced
this pull request
May 29, 2025
Related: - discourse/discourse-translator#308 - #32920 (setting introduced) Moving the switcher to core, as the setting is now in core.
megothss
pushed a commit
to discourse/discourse
that referenced
this pull request
Jun 3, 2025
Related: - discourse/discourse-translator#308 - #32920 (setting introduced) Moving the switcher to core, as the setting is now in core.
martin-brennan
pushed a commit
to discourse/discourse
that referenced
this pull request
Jun 10, 2025
Related: - discourse/discourse-translator#308 - #32920 (setting introduced) Moving the switcher to core, as the setting is now in core.
nattsw
added a commit
to discourse/discourse
that referenced
this pull request
Aug 19, 2025
When this button was moved from translator to core (discourse/discourse-translator#308) the translations were not updated. This commit fixes the missing translation.
yuriyaran
pushed a commit
to discourse/discourse
that referenced
this pull request
Aug 21, 2025
When this button was moved from translator to core (discourse/discourse-translator#308) the translations were not updated. This commit fixes the missing translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anon language switcher feature is moving to core, so we are removing it from this plugin.
Similarly, in discourse/discourse#32920, we introduced
experimental_content_localization_supported_locales, but there was a borked migration that copiesautomatic_translation_target_languages(from this plugin) toexperimental_content_localization_supported_locales(core) - the migration was a no-op. Language switcher relies on old setting, so it was good it was borked. This PR also adds a migration to do a rename as the old setting will not be used any more./t/154911