DEV: Update linting (#50)

Author: CvX

Gemfile.lock

@@ -1,8 +1,9 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.2.1.1)
+    activesupport (8.0.2)
       base64
+      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
@@ -12,68 +13,81 @@ GEM
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
     ast (2.4.2)
     base64 (0.2.0)
-    bigdecimal (3.1.8)
-    concurrent-ruby (1.3.4)
-    connection_pool (2.4.1)
+    benchmark (0.4.0)
+    bigdecimal (3.1.9)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.0)
     drb (2.2.1)
-    i18n (1.14.6)
+    i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.7.2)
-    language_server-protocol (3.17.0.3)
-    logger (1.6.1)
-    minitest (5.25.1)
+    json (2.10.2)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
+    logger (1.6.6)
+    minitest (5.25.5)
     parallel (1.26.3)
-    parser (3.3.5.0)
+    parser (3.3.7.1)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
     racc (1.8.1)
-    rack (3.1.8)
+    rack (3.1.12)
     rainbow (3.1.1)
-    regexp_parser (2.9.2)
-    rubocop (1.67.0)
+    regexp_parser (2.10.0)
+    rubocop (1.74.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 2.4, < 3.0)
-      rubocop-ast (>= 1.32.2, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.32.3)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.39.0)
       parser (>= 3.3.1.0)
-    rubocop-capybara (2.21.0)
-      rubocop (~> 1.41)
-    rubocop-discourse (3.8.2)
+    rubocop-capybara (2.22.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-discourse (3.12.1)
       activesupport (>= 6.1)
-      rubocop (>= 1.59.0)
-      rubocop-capybara (>= 2.0.0)
-      rubocop-factory_bot (>= 2.0.0)
-      rubocop-rails (>= 2.25.0)
+      lint_roller (>= 1.1.0)
+      rubocop (>= 1.73.2)
+      rubocop-capybara (>= 2.22.0)
+      rubocop-factory_bot (>= 2.27.0)
+      rubocop-rails (>= 2.30.3)
       rubocop-rspec (>= 3.0.1)
-      rubocop-rspec_rails (>= 2.30.0)
-    rubocop-factory_bot (2.26.1)
-      rubocop (~> 1.61)
-    rubocop-rails (2.26.2)
+      rubocop-rspec_rails (>= 2.31.0)
+    rubocop-factory_bot (2.27.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-rails (2.30.3)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.52.0, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rspec (3.1.0)
-      rubocop (~> 1.61)
-    rubocop-rspec_rails (2.30.0)
-      rubocop (~> 1.61)
-      rubocop-rspec (~> 3, >= 3.0.1)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rspec (3.5.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-rspec_rails (2.31.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-rspec (~> 3.5)
     ruby-progressbar (1.13.0)
-    securerandom (0.3.1)
+    securerandom (0.4.1)
     syntax_tree (6.2.0)
       prettier_print (>= 1.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.6.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    uri (1.0.3)
 
 PLATFORMS
   arm64-darwin-23
@@ -84,4 +98,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.5.21
+   2.6.6

common/common.scss

@@ -3,6 +3,7 @@
     display: none !important;
   }
 }
+
 @if $display_on_mobile == "false" {
   .mobile-view .banner-box {
     display: none !important;
@@ -17,11 +18,14 @@
   .above-site-header-outlet {
     order: -4;
   }
+
   .d-header-wrap {
     order: -3;
   }
+
   .below-site-header-outlet {
     order: -1;
+
     & + .below-site-header-outlet {
       order: -2;
     }
@@ -37,6 +41,7 @@
   #main > div {
     .below-site-header-outlet {
       order: -2;
+
       & + .below-site-header-outlet {
         order: -1;
       }
@@ -77,18 +82,20 @@
       svg {
         color: #646464;
       }
+
       .d-button-label {
         font-size: 1em;
         color: #646464;
       }
 
       &:hover {
         svg {
-          color: #222222;
+          color: #222;
         }
+
         .d-button-label {
           font-size: 1em;
-          color: #222222;
+          color: #222;
         }
       }
 
@@ -139,7 +146,7 @@
       float: left;
       position: relative;
       min-height: 1px;
-      padding: 0px 15px 30px;
+      padding: 0 15px 30px;
       text-align: center;
 
       .icon {
@@ -157,6 +164,7 @@
       .banner-list {
         display: flex;
         justify-content: center;
+
         ul {
           text-align: left;
           margin: 0;
@@ -177,11 +185,10 @@
   }
 }
 
-//-------------------------- Setting Based Rules --------------------------//
-//                      Modified using theme settings
-//-------------------------------------------------------------------------//
+// Setting Based Rules
+// Modified using theme settings
 
-////////////// Columns //////////////
+// Columns
 
 // First column
 @if $first_column_size == "auto" {
@@ -231,7 +238,7 @@
   }
 }
 
-////////////// Full Width //////////////
+// Full Width
 
 @if $full_width_banner == "true" {
   #main .banner-box {
@@ -270,6 +277,7 @@
       button {
         padding: 5px 5px;
       }
+
       .d-button-label {
         display: none;
       }
@@ -301,7 +309,6 @@
 // we can't animate with auto height, so we need a big max-height to cover variable content
 // if the content is taller than the max-height, this will need to be adjusted
 // but if it's too large, clicking collapse animation will feel laggy
-
 #banner-content_wrap {
   overflow: hidden;
   max-height: 1000px;

javascripts/discourse/components/versatile-banner.js

@@ -11,6 +11,7 @@ export default class VersatileBanner extends Component {
   @service router;
   @service site;
   @service currentUser;
+
   @tracked bannerClosed = this.cookieClosed || false;
   @tracked
   bannerCollapsed =

package.json

@@ -1,10 +1,11 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.4.0",
-    "ember-template-lint": "6.1.0",
-    "eslint": "9.19.0",
-    "prettier": "2.8.8"
+    "@discourse/lint-configs": "2.11.1",
+    "ember-template-lint": "7.0.1",
+    "eslint": "9.22.0",
+    "prettier": "3.5.3",
+    "stylelint": "16.16.0"
   },
   "engines": {
     "node": ">= 22",