DEV: Move extern gems to compile separately

Remove make, g++, and -dev packages from base image.
Compile gems that need it separately, and copy after compile.
Install make and g++ to install redis

Reduce size of docker image by 250MB

TODO: need to figure out a way of recompiling gems that require compilation.
Otherwise the gems that require external compilation steps will not be able to
install with bundle.

Author: featheredtoast

image/base/Dockerfile

@@ -72,14 +72,13 @@ RUN --mount=type=tmpfs,target=/var/log \
     echo "debconf debconf/frontend select Teletype" | debconf-set-selections; \
     apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get -y install gnupg sudo curl fping locales \
     ca-certificates rsync \
-    cmake g++ pkg-config patch \
-    libxslt-dev libcurl4-openssl-dev \
-    libssl-dev libyaml-dev libtool \
-    libpcre3 libpcre3-dev zlib1g zlib1g-dev \
-    libxml2-dev gawk parallel \
-    libreadline-dev anacron wget \
-    psmisc whois brotli libunwind-dev \
-    libtcmalloc-minimal4 cmake \
+    pkg-config patch \
+    libtool \
+    libpcre3 zlib1g \
+    gawk parallel \
+    anacron wget \
+    psmisc whois brotli \
+    libtcmalloc-minimal4 \
     pngcrush pngquant ripgrep poppler-utils \
 # imagemagick runtime dependencies
     ghostscript libjbig0 libtiff6 libpng16-16 libfontconfig1 \
@@ -108,7 +107,7 @@ RUN --mount=type=tmpfs,target=/var/log \
     dpkg-divert --local --rename --add /sbin/initctl; \
     sh -c "test -f /sbin/initctl || ln -s /bin/true /sbin/initctl"; \
     apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get -y install runit socat \
-    libpq-dev postgresql-client-${PG_MAJOR} \
+    postgresql-client-${PG_MAJOR} \
     nodejs yarn &&\
     mkdir -p /etc/runit/1.d
 
@@ -169,21 +168,51 @@ RUN install -dm 0755 -o discourse -g discourse /var/www/discourse &&\
     sudo -u discourse git clone --branch $DISCOURSE_BRANCH --filter=tree:0 https://github.com/discourse/discourse.git /var/www/discourse &&\
     gem install bundler --conservative -v $(awk '/BUNDLED WITH/ { getline; gsub(/ /,""); print $0 }' /var/www/discourse/Gemfile.lock)
 
+FROM discourse_slim AS discourse_gem_builder
+RUN --mount=type=tmpfs,target=/var/log \
+    apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get -y install \
+    cmake g++ \
+    libxslt-dev libcurl4-openssl-dev \
+    libssl-dev libyaml-dev \
+    libpcre3-dev zlib1g-dev \
+    libxml2-dev \
+    libreadline-dev \
+    libunwind-dev \
+    libpq-dev
+RUN cd /var/www/discourse &&\
+  sudo -u discourse bundle config --local deployment true &&\
+  sudo -u discourse bundle config --local path ./vendor/bundle &&\
+  sudo -u discourse bundle config --local without test development &&\
+  sudo -u discourse bundle install --jobs $(($(nproc) - 1)) &&\
+  find /var/www/discourse/vendor/bundle -name cache -not -path '*/gems/*' -type d -exec rm -rf {} + &&\
+  find /var/www/discourse/vendor/bundle -name tmp -type d -exec rm -rf {} + &&\
+# Delete compile time libv8 library
+  find /var/www/discourse/vendor/bundle -wholename "*libv8-node*/vendor" -type d -exec rm -rf {} +
+
 FROM discourse_slim AS discourse_web_only
 ENV RAILS_ENV=production
 
 RUN cd /var/www/discourse &&\
-    sudo -u discourse bundle config --local deployment true &&\
-    sudo -u discourse bundle config --local path ./vendor/bundle &&\
-    sudo -u discourse bundle config --local without test development &&\
-    sudo -u discourse bundle install --jobs $(($(nproc) - 1)) &&\
-    find /var/www/discourse/vendor/bundle -name cache -not -path '*/gems/*' -type d -exec rm -rf {} + &&\
-    find /var/www/discourse/vendor/bundle -name tmp -type d -exec rm -rf {} +
+  sudo -u discourse bundle config --local deployment true &&\
+  sudo -u discourse bundle config --local path ./vendor/bundle &&\
+  sudo -u discourse bundle config --local without test development
+COPY --from=discourse_gem_builder /var/www/discourse/vendor/bundle /var/www/discourse/vendor/bundle
 
 RUN cd /var/www/discourse &&\
     sudo -u discourse /bin/bash -c 'if [ -f yarn.lock ]; then yarn install --frozen-lockfile && yarn cache clean; else pnpm install --frozen-lockfile; fi'
 
 FROM discourse_web_only AS discourse_release
+
+RUN --mount=type=tmpfs,target=/var/log \
+    apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get -y install \
+    cmake g++ \
+    libxslt-dev libcurl4-openssl-dev \
+    libssl-dev libyaml-dev \
+    libpcre3-dev zlib1g-dev \
+    libxml2-dev \
+    libreadline-dev \
+    libunwind-dev \
+    libpq-dev
 RUN --mount=type=tmpfs,target=/var/log \
   apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get -y install \
   postgresql-${PG_MAJOR} postgresql-contrib-${PG_MAJOR} postgresql-${PG_MAJOR}-pgvector

image/discourse_dev/Dockerfile

@@ -16,6 +16,7 @@ FROM discourse/base:$from_tag
 # Install Postgres and Redis
 RUN --mount=type=tmpfs,target=/var/log \
   apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get -y install \
+  cmake g++ \
   postgresql-${PG_MAJOR} postgresql-contrib-${PG_MAJOR} postgresql-${PG_MAJOR}-pgvector
 RUN /tmp/install-redis
 

image/discourse_test/Dockerfile

@@ -13,6 +13,7 @@ RUN sudo -E -u discourse -H git config --global user.email "[email protected]" &&\
 # Include postgres and redis on test images
 RUN --mount=type=tmpfs,target=/var/log \
   apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get -y install \
+  cmake g++ \
   postgresql-${PG_MAJOR} postgresql-contrib-${PG_MAJOR} postgresql-${PG_MAJOR}-pgvector
 RUN /tmp/install-redis