Skip to content

Commit fe48fa2

Browse files
authored
Switch to discourse/ruby:3.3.4-bookworm-slim (#853)
1 parent 44134a2 commit fe48fa2

File tree

5 files changed

+28
-48
lines changed

5 files changed

+28
-48
lines changed

image/auto_build.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@
3737
discourse_dev_amd64: {
3838
name: "discourse_dev",
3939
tag: "discourse/discourse_dev:build_amd64",
40-
extra_args: "--build-arg=\"from_tag=build_slim_amd64\""
40+
extra_args: "--build-arg=\"from_tag=build_slim_amd64\"",
4141
},
4242
discourse_dev_arm64: {
4343
name: "discourse_dev",
4444
tag: "discourse/discourse_dev:build_arm64",
45-
extra_args: "--platform linux/arm64 --build-arg=\"from_tag=build_slim_arm64\""
46-
}
45+
extra_args: "--platform linux/arm64 --build-arg=\"from_tag=build_slim_arm64\"",
46+
},
4747
}
4848

4949
def run(command)

image/base/install-oxipng

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,24 @@
22
set -e
33

44
# version check: https://github.com/shssoichiro/oxipng/releases
5-
OXIPNG_VERSION="8.0.0"
6-
OXIPNG_HASH="ef96d6340e70900de0a38ace8f5f20878f6c256b18b0c59cd87f2b515437b87b"
7-
OXIPNG_ARCHIVE="v${OXIPNG_VERSION}.tar.gz"
8-
OXIPNG_DIR="oxipng-${OXIPNG_VERSION}"
5+
OXIPNG_VERSION="9.1.2"
6+
dpkgArch="$(dpkg --print-architecture)"
97

10-
# Install other deps
11-
apt-get -y install advancecomp jhead jpegoptim libjpeg-turbo-progs optipng
12-
13-
cd /tmp
14-
wget -q https://github.com/shssoichiro/oxipng/archive/refs/tags/${OXIPNG_ARCHIVE}
15-
sha256sum ${OXIPNG_ARCHIVE}
16-
echo "${OXIPNG_HASH} ${OXIPNG_ARCHIVE}" | sha256sum -c
8+
case "${dpkgArch##*-}" in
9+
amd64) OXIPNG_FILE="oxipng-${OXIPNG_VERSION}-x86_64-unknown-linux-musl.tar.gz"; OXIPNG_HASH='211d53f3781be4a71566fbaad6611a3da018ac9b22d500651b091c2b42ebe318' ;;
10+
arm64) OXIPNG_FILE="oxipng-${OXIPNG_VERSION}-aarch64-unknown-linux-musl.tar.gz"; OXIPNG_HASH='818d47d7195e1e0c4d58a9f3b6fd84aa3cd21770c60c876e73e2e6a17ca69b52' ;;
11+
*) echo >&2 "unsupported architecture: ${dpkgArch}"; exit 1 ;;
12+
esac
1713

18-
tar -zxf ${OXIPNG_ARCHIVE}
19-
cd ${OXIPNG_DIR}
14+
# Install other deps
15+
apt -y -q install advancecomp jhead jpegoptim libjpeg-turbo-progs optipng
2016

21-
CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse /usr/local/cargo/bin/cargo build --release
22-
cp target/release/oxipng /usr/local/bin
17+
mkdir /oxipng-install
18+
cd /oxipng-install
2319

24-
cd / && rm -fr /tmp/${OXIPNG_DIR} && rm -f /tmp/${OXIPNG_ARCHIVE}
20+
wget -q https://github.com/shssoichiro/oxipng/releases/download/v${OXIPNG_VERSION}/${OXIPNG_FILE}
21+
sha256sum ${OXIPNG_FILE}
22+
echo "${OXIPNG_HASH} ${OXIPNG_FILE}" | sha256sum -c
23+
tar --strip-components=1 -xzf $OXIPNG_FILE
24+
cp -v ./oxipng /usr/local/bin
25+
cd / && rm -fr /oxipng-install

image/base/install-ruby

Lines changed: 0 additions & 16 deletions
This file was deleted.

image/base/slim.Dockerfile

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,12 @@
22
# VERSION: release
33

44
ARG DEBIAN_RELEASE=bookworm
5-
FROM debian:${DEBIAN_RELEASE}-slim
5+
FROM discourse/ruby:3.3.4-${DEBIAN_RELEASE}-slim
66

77
ARG DEBIAN_RELEASE
8-
ARG RUBY_VERSION=3.3.4
98
ENV PG_MAJOR=13 \
109
RUBY_ALLOCATOR=/usr/lib/libjemalloc.so \
11-
RUSTUP_HOME=/usr/local/rustup \
12-
CARGO_HOME=/usr/local/cargo \
13-
PATH=/usr/local/cargo/bin:$PATH \
1410
LEFTHOOK=0 \
15-
RUBY_VERSION=${RUBY_VERSION} \
1611
DEBIAN_RELEASE=${DEBIAN_RELEASE}
1712

1813
#LABEL maintainer="Sam Saffron \"https://twitter.com/samsaffron\""
@@ -92,10 +87,8 @@ RUN gpg --import /tmp/nginx_public_keys.key &&\
9287
ADD install-redis /tmp/install-redis
9388
RUN /tmp/install-redis
9489

95-
ADD install-rust /tmp/install-rust
96-
ADD install-ruby /tmp/install-ruby
9790
ADD install-oxipng /tmp/install-oxipng
98-
RUN /tmp/install-rust && /tmp/install-ruby $RUBY_VERSION && /tmp/install-oxipng && rustup self uninstall -y
91+
RUN /tmp/install-oxipng
9992

10093
RUN echo 'gem: --no-document' >> /usr/local/etc/gemrc &&\
10194
gem update --system
@@ -119,7 +112,6 @@ RUN rm -fr /usr/share/man &&\
119112
rm -fr /usr/share/vim/vim74/tutor &&\
120113
rm -fr /usr/local/share/doc &&\
121114
rm -fr /usr/local/share/ri &&\
122-
rm -fr /usr/local/share/ruby-build &&\
123115
rm -fr /var/lib/apt/lists/* &&\
124116
rm -fr /root/.gem &&\
125117
rm -fr /root/.npm &&\

image/discourse_dev/Dockerfile

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,12 @@ ADD redis.template.yml /pups/redis.yml
2929
RUN /pups/bin/pups /pups/redis.yml
3030

3131
RUN locale-gen en_US.UTF-8
32-
ENV LANG en_US.UTF-8
33-
ENV LANGUAGE en_US:en
34-
ENV LC_ALL en_US.UTF-8
32+
ENV LANG=en_US.UTF-8 \
33+
LANGUAGE=en_US:en \
34+
LC_ALL=en_US.UTF-8 \
35+
RUSTUP_HOME=/usr/local/rustup \
36+
CARGO_HOME=/usr/local/cargo \
37+
PATH=/usr/local/cargo/bin:$PATH
3538

3639
# get postgres going
3740
ADD postgres.template.yml /pups/postgres.yml

0 commit comments

Comments
 (0)