Modernize dev dependencies management (#348)

* Move prometheus_exporter bin to exe directory

* Add binstub for Rubocop (it's shorter to type/remember)

* Move dev dependencies in Gemfile

* Add binstub for Rake (it's shorter to type/remember)

* Don't rely on git to build bundler manifest

* Add binstub for Appraisal (it's shorter to type/remember)

* Drop support of AR 6.0 (not present in CI matrix)

* Add AR 7.1 in Appraisals file

* Add support for AR 8.0

* Drop support for Ruby 3.1 (EOL: 2025-03-26)

* Add support for Ruby 3.4

* Ignore bundler project cache

* Don't let bundler autoclean gems (Appraisal will fail later because of missing gems)

* Use latest Appraisal version

* Fix failing CI with AR 6.1/7.0 and Ruby 3.4

* Add binstub for syntax_tree (it's shorter to type/remember)

* Fix failing CI with AR 6.1 and Ruby 3.4

* Fix Rubocop offense

* Fix stree formatting

Author: n-rodriguez

.github/workflows/ci.yml

@@ -27,8 +27,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ["3.1", "3.2", "3.3"]
-        activerecord: [61, 70, 71]
+        ruby: ["3.2", "3.3", "3.4"]
+        activerecord: [61, 70, 71, 80]
 
     steps:
       - uses: actions/checkout@v4

.gitignore

@@ -8,6 +8,7 @@
 /tmp/
 Gemfile.lock
 /gemfiles/*.gemfile.lock
+/gemfiles/.bundle
 
 
 .rubocop-https---raw-githubusercontent-com-discourse-discourse-master--rubocop-yml

.rubocop.yml

@@ -3,6 +3,7 @@ inherit_gem:
 
 AllCops:
   Exclude:
+    - 'bin/*'
     - 'gemfiles/**/*'
     - 'vendor/**/*'
 
@@ -11,7 +12,7 @@ Discourse/Plugins/NoMonkeyPatching:
 
 Discourse/Plugins/NamespaceMethods:
   Exclude:
-    - bin/prometheus_exporter
+    - exe/prometheus_exporter
 
 Style/InvertibleUnlessCondition:
   Exclude:

Appraisals

@@ -1,14 +1,32 @@
 # frozen_string_literal: true
 
-appraise "ar-60" do
-  gem "activerecord", "~> 6.0.0"
-end
-
 appraise "ar-61" do
   gem "activerecord", "~> 6.1.1"
+
+  # Fix:
+  # warning: mutex_m was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0.
+  # Add mutex_m to your Gemfile or gemspec.
+  install_if '-> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0") }' do
+    gem 'base64'
+    gem 'mutex_m'
+  end
 end
 
 appraise "ar-70" do
-  # latest version
-  gem "activerecord", "~> 7.1.2"
+  gem "activerecord", "~> 7.0.0"
+
+  # Fix:
+  # warning: mutex_m was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0.
+  # Add mutex_m to your Gemfile or gemspec.
+  install_if '-> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0") }' do
+    gem 'mutex_m'
+  end
+end
+
+appraise "ar-71" do
+  gem "activerecord", "~> 7.1.0"
+end
+
+appraise "ar-80" do
+  gem "activerecord", "~> 8.0.0"
 end

Gemfile

@@ -2,7 +2,26 @@
 
 source "https://rubygems.org"
 
-git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
-
-# Specify your gem's dependencies in prometheus_exporter.gemspec
 gemspec
+
+# Dev libs
+gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
+gem "activerecord", "~> 7.1"
+gem "bundler", ">= 2.1.4"
+gem "m"
+gem "mini_racer", "~> 0.12.0"
+gem "minitest", "~> 5.23.0"
+gem "minitest-stub-const", "~> 0.6"
+gem "oj", "~> 3.0"
+gem "rack-test", "~> 2.1.0"
+gem "rake", "~> 13.0"
+gem "redis", "> 5"
+gem "syntax_tree"
+gem "syntax_tree-disable_ternary"
+gem "raindrops", "~> 0.19" if !RUBY_ENGINE == "jruby"
+
+# Dev tools / linter
+gem "guard", "~> 2.0", require: false
+gem "guard-minitest", "~> 2.0", require: false
+gem "rubocop", ">= 0.69", require: false
+gem "rubocop-discourse", ">= 3", require: false

bin/appraisal

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'appraisal' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("appraisal", "appraisal")

bin/rake

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rake' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rake", "rake")

bin/rubocop

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rubocop' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rubocop", "rubocop")

bin/stree

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'stree' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("syntax_tree", "stree")