GoodJobCollector refactor

Author: benngarcia

lib/prometheus_exporter/server/good_job_collector.rb

@@ -23,28 +23,9 @@ def type
     end
 
     def metrics
-      return [] if good_job_metrics.length == 0
-
-      good_job_metrics.map do |metric|
-        labels = metric.fetch("custom_labels", {})
-
-        GOOD_JOB_GAUGES.map do |name, help|
-          value = metric[name.to_s]
-
-          if value
-            gauge = gauges[name] ||= PrometheusExporter::Metric::Gauge.new("good_job_#{name}", help)
-
-            if metric["by_queue"]
-              value.each do |queue_name, count|
-                gauge.observe(count, labels.merge(queue_name: queue_name))
-              end
-            else
-              gauge.observe(value, labels)
-            end
-          end
-        end
-      end
+      return [] if good_job_metrics.empty?
 
+      good_job_metrics.each(&method(:process_metric))
       gauges.values
     end
 
@@ -55,5 +36,24 @@ def collect(object)
     private
 
     attr_reader :good_job_metrics, :gauges
+
+    def process_metric(metric)
+      labels = metric.fetch("custom_labels", {})
+
+      GOOD_JOB_GAUGES.each do |name, help|
+        next unless (value = metric[name.to_s])
+
+        gauge = gauges[name] ||= PrometheusExporter::Metric::Gauge.new("good_job_#{name}", help)
+        observe_metric(gauge, metric, labels, value)
+      end
+    end
+
+    def observe_metric(gauge, metric, labels, value)
+      if metric["by_queue"]
+        value.each { |queue_name, count| gauge.observe(count, labels.merge(queue_name: queue_name)) }
+      else
+        gauge.observe(value, labels)
+      end
+    end
   end
 end