feat: Show important scenario attributes in result

Author: marcustyphoon

locales/en/translation.json

@@ -120,6 +120,7 @@
   "Infusions: ": "Infusions: ",
   "Invalid Format.": "Invalid Format.",
   "Jump to sharing section": "Jump to sharing section",
+  "Key Scenario Attributes": "Key Scenario Attributes",
   "Life Siphon": "Life Siphon",
   "Lifesteal frequency:": "Lifesteal frequency:",
   "Lock any gear slots to a specific type to work with what you already have or share gear between multiple builds.": "Lock any gear slots to a specific type to work with what you already have or share gear between multiple builds.",

src/components/sections/results/ResultDetails.tsx

@@ -21,6 +21,7 @@ import OtherAttributes from './OtherAttributes';
 import OutputDistribution from './OutputDistribution';
 import OutputInfusions from './OutputInfusions';
 import ResultCharacter from './ResultCharacter';
+import ScenarioAttributeSummary from './ScenarioAttributeSummary';
 import SpecialDurations from './SpecialDurations';
 import TemplateHelperSections from './TemplateHelperSections';
 
@@ -89,6 +90,7 @@ const ResultDetails = () => {
           <MultiplierBreakdown character={character} />
         </Grid>
       </Grid>
+      <ScenarioAttributeSummary character={character} />
       <AppliedModifiers character={character} />
       <TemplateHelperSections character={character} />
     </ErrorBoundary>

src/components/sections/results/ScenarioAttributeSummary.tsx

@@ -0,0 +1,48 @@
+import DataSaverOnIcon from '@mui/icons-material/DataSaverOn';
+import { Grid, Table, TableBody, TableCell, TableRow, Typography } from '@mui/material';
+import { Trans } from 'react-i18next';
+import { allAttributePercentKeys } from '../../../assets/modifierdata/metadata';
+import type { Character } from '../../../state/optimizer/types/optimizerTypes';
+
+const roundOne = (num: number) => Math.round(num * 10) / 10;
+const roundTwo = (num: number) => Math.round(num * 100) / 100;
+
+const ScenarioAttributeSummary = ({ character }: { character: Character }) => {
+  if (character.results.scenarioAttributeSummary) {
+    return (
+      <>
+        <Typography variant="h6">
+          <DataSaverOnIcon color="info" fontSize="small" sx={{ marginRight: '0.5ch' }} />
+          <Trans>Key Scenario Attributes</Trans>
+        </Typography>
+        <Grid container spacing={2} mb={2}>
+          {Object.entries(character.results.scenarioAttributeSummary).map(
+            ([attribute, entries]) => (
+              <Grid size={{ xs: 12, sm: 8, md: 4 }}>
+                <Table padding="none" sx={{ mb: 0 }}>
+                  <TableBody>
+                    {entries.map(([value, amount]) => (
+                      <TableRow hover key={value}>
+                        <TableCell>
+                          <Typography sx={{ fontSize: '18px', color: '#AAAAAA' }}>
+                            {allAttributePercentKeys.includes(attribute)
+                              ? `${(value * 100).toFixed(2)}%`
+                              : roundOne(value)}{' '}
+                            {attribute}
+                          </Typography>
+                        </TableCell>
+                        <TableCell align="right">{roundTwo(amount * 100)}%</TableCell>
+                      </TableRow>
+                    ))}
+                  </TableBody>
+                </Table>
+              </Grid>
+            ),
+          )}
+        </Grid>
+      </>
+    );
+  }
+};
+
+export default ScenarioAttributeSummary;

src/state/optimizer/optimizerCore.ts

@@ -26,6 +26,7 @@ import type {
   OptimizerCoreSettings,
   Results,
   Scenario,
+  ScenarioAttributeSummary,
   ScenarioProcessed,
 } from './types/optimizerTypes';
 import { iteratePartitions } from './utils/combinatorics';
@@ -976,6 +977,29 @@ export class OptimizerCore {
       };
     }
 
+    if (character.scenarios.length > 1) {
+      const scenarioAttributeSummary: ScenarioAttributeSummary = {};
+      let hasData = false;
+
+      const attrs = ['Critical Chance', 'Condition Duration'] as const;
+      for (const attr of attrs) {
+        const map = new Map<number, number>();
+        scenarios.forEach((scenario) =>
+          map.set(
+            scenario.attributes[attr],
+            (map.get(scenario.attributes[attr]) ?? 0) + scenario.fraction,
+          ),
+        );
+        if (map.size > 1) {
+          scenarioAttributeSummary[attr] = [...map.entries()].sort((a, b) => a[0] - b[0]);
+          hasData = true;
+        }
+      }
+      if (hasData) {
+        results.scenarioAttributeSummary = scenarioAttributeSummary;
+      }
+    }
+
     // out of combat hero panel simulation (overrides both baseAttributes and modifiers)
     if (settings.unbuffedBaseAttributes && settings.unbuffedModifiers) {
       const unbuffedScenario: Scenario = {

src/state/optimizer/types/optimizerTypes.ts

@@ -161,6 +161,8 @@ interface CoefficientHelperValue {
 }
 export type EffectiveDistributionKey = DistributionNameInternal | 'Other' | 'Siphon';
 type GainLossKey = 'Power' | 'Precision' | 'Ferocity' | 'Condition Damage' | 'Expertise';
+
+export type ScenarioAttributeSummary = Partial<Record<AttributeName, [number, number][]>>;
 export interface Results {
   value: number;
   indicators: Record<IndicatorName, number>;
@@ -170,6 +172,7 @@ export interface Results {
   damageBreakdown?: Partial<Record<EffectiveDistributionKey, number>>;
   coefficientHelper?: Partial<Record<DistributionNameInternal, CoefficientHelperValue>>;
   unbuffedAttributes?: Attributes;
+  scenarioAttributeSummary?: ScenarioAttributeSummary;
 }
 export interface CharacterUnprocessed {
   id?: string;