data: Add note about inaccurate spite signet approximation

Author: marcustyphoon

locales/en/translation.json

@@ -297,6 +297,7 @@
   "amountLabel_% fury": "% fury",
   "amountLabel_% impaired": "% impaired",
   "amountLabel_% melee": "% melee",
+  "amountLabel_% of non-shroud": "% of non-shroud",
   "amountLabel_% regeneration": "% regeneration",
   "amountLabel_% resolution": "% resolution",
   "amountLabel_% revealed": "% revealed",
@@ -1138,6 +1139,7 @@
   "skillSubText_siphon effect, vs vulnerable": "siphon effect, vs vulnerable",
   "skillSubText_siphon only": "siphon only",
   "skillSubText_traited": "traited",
+  "skillSubText_when not in shroud": "when not in shroud",
   "skillSubText_while active": "while active",
   "skillSubText_with Centaur, while active": "with Centaur, while active",
   "skillSubText_woven air / perfect weave": "woven air / perfect weave",
@@ -1175,8 +1177,8 @@
   "traitNote_Larcenous Torment lifesteal damage may be omitted in arcdps area stats or parsed arcdps logs.": "Larcenous Torment lifesteal damage may be omitted in arcdps area stats or parsed arcdps logs.",
   "traitNote_Leeching venoms siphons applied by allies use allies' power stats, so they are not implemented.": "Leeching venoms siphons applied by allies use allies' power stats, so they are not implemented.",
   "traitNote_Natural Fortitude Unleashed Ambush lifesteal damage may be omitted in arcdps area stats or parsed arcdps logs.": "Natural Fortitude Unleashed Ambush lifesteal damage may be omitted in arcdps area stats or parsed arcdps logs.",
-  "traitNote_Nightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.": "Nightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.",
   "traitNote_Non-100% Chaotic Potency with-staff values combined with Toxic Maintenance Oil/Enhanced Lucent Oil result in inconsistent boon duration between weapon sets, which will be averaged.": "Non-100% Chaotic Potency with-staff values combined with Toxic Maintenance Oil/Enhanced Lucent Oil result in inconsistent boon duration between weapon sets, which will be averaged.",
+  "traitNote_Signet of Spite non-100% uptime (i.e. on any build that uses shroud rotation) is currently simulated poorly (as a fractional affect both in and out of shroud).\n\nNightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.": "Signet of Spite non-100% uptime (i.e. on any build that uses shroud rotation) is currently simulated poorly (as a fractional affect both in and out of shroud).\n\nNightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.",
   "traitNote_The durations of transferred self conditions (cannon backfire + generosity sigil) aren't simulated correctly.": "The durations of transferred self conditions (cannon backfire + generosity sigil) aren't simulated correctly.",
   "traitNote_The durations of transferred self conditions (plague sending, dagger 4, staff 4) aren't simulated correctly.": "The durations of transferred self conditions (plague sending, dagger 4, staff 4) aren't simulated correctly.",
   "traitNote_Vampiric Slash lifesteal damage may not be shown in arcdps area stats or parsed arcdps logs.": "Vampiric Slash lifesteal damage may not be shown in arcdps area stats or parsed arcdps logs.",

src/assets/modifierdata/necromancer.yaml

@@ -1,5 +1,9 @@
 - section: Skills
   note: >-
+    Signet of Spite non-100% uptime (i.e. on any build that uses shroud rotation) is currently simulated poorly
+    (as a fractional affect both in and out of shroud).
+
+
     Nightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul
     Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.
   items:
@@ -17,13 +21,14 @@
           Flat DPS: 1
       temporaryBuff: true
 
+    # kind of inaccurate; shouldn't apply in shroud and shouldn't affect "alternative power"
     - id: signet-of-spite
       text: Signet of Spite
-      subText: passive
+      subText: when not in shroud
       amountData:
-        label: '% uptime'
+        label: '% of non-shroud'
         default: 0
-        defaultInput: ???
+        defaultInput: 100
         quantityEntered: 100
       modifiers:
         attributes: