Skip to content

Commit eef9dc6

Browse files
marcustyphoonmarcustyphoon
authored
data: Fix incorrect fire signet amounts (#986)
1 parent 2af98b5 commit eef9dc6

File tree

6 files changed

+47
-28
lines changed

6 files changed

+47
-28
lines changed

‎locales/en/translation.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@
379379
"buildTemplateName_Condi Barrier \"Carrion\" Specter SC/D": "Condi Barrier \"Carrion\" Specter SC/D",
380380
"buildTemplateName_Condi Berserker Blademaster": "Condi Berserker Blademaster",
381381
"buildTemplateName_Condi Berserker UF": "Condi Berserker UF",
382-
"buildTemplateName_Condi Catalyst P/D Steamshrieker": "Condi Catalyst P/D Steamshrieker",
382+
"buildTemplateName_Condi Catalyst P/D Steamshrieker (Approx.)": "Condi Catalyst P/D Steamshrieker (Approx.)",
383383
"buildTemplateName_Condi Chrono Scepter": "Condi Chrono Scepter",
384384
"buildTemplateName_Condi Chrono Staff SC/D (Approx.)": "Condi Chrono Staff SC/D (Approx.)",
385385
"buildTemplateName_Condi Daredevil": "Condi Daredevil",
@@ -897,8 +897,8 @@
897897
"preset_extra_Power Quickness Herald (Raid)": "Power Quickness Herald (Raid)",
898898
"preset_extra_Power Quickness Untamed (Raid)": "Power Quickness Untamed (Raid)",
899899
"preset_extra_Power Staff Daredevil": "Power Staff Daredevil",
900-
"preset_extra_Power Tempest Bloodstone (Fractal)": "Power Tempest Bloodstone (Fractal)",
901-
"preset_extra_Power Tempest Bloodstone (Raid)": "Power Tempest Bloodstone (Raid)",
900+
"preset_extra_Power Tempest Inferno (Fractal)": "Power Tempest Inferno (Fractal)",
901+
"preset_extra_Power Tempest Inferno (Raid)": "Power Tempest Inferno (Raid)",
902902
"preset_extra_Power Weaver (Raid)": "Power Weaver (Raid)",
903903
"preset_extra_Power Willbender Virtues (Fractal)": "Power Willbender Virtues (Fractal)",
904904
"preset_extra_Quickness Condi Deadeye Spear": "Quickness Condi Deadeye Spear",

‎src/assets/presetdata/preset-distribution.yaml‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ list:
489489
profession: Tempest
490490
value:
491491
{
492-
"values2": { "Power": 2657, "Power2": 0, "Burning": 10.65, "Bleeding": 19.24, "Poisoned": 0, "Torment": 0, "Confusion": 0 }
492+
"values2": { "Power": 2588, "Power2": 0, "Burning": 10.65, "Bleeding": 19.24, "Poisoned": 0, "Torment": 0, "Confusion": 0 }
493493
}
494494
credit:
495495
- author: '[NA] Crone'
@@ -529,17 +529,16 @@ list:
529529
url: https://www.youtube.com/watch?v=50-VmnennEs
530530
log: https://dps.report/0kW0-20251120-143549_golem
531531

532-
# use bloodstone-relic-prenerf-2 if resimulating
533532
- name: Power Tempest Inferno
534533
profession: Tempest
535534
value:
536535
{
537-
"values2": { "Power": 3795, "Power2": 0, "Burning": 10.68, "Bleeding": 4.54, "Poisoned": 0, "Torment": 0, "Confusion": 0 }
536+
"values2": { "Power": 3685, "Power2": 0, "Burning": 10.5, "Bleeding": 4.37, "Poisoned": 0, "Torment": 0, "Confusion": 0 }
538537
}
539538
credit:
540-
- author: '[NA] Crone'
541-
url: https://www.youtube.com/watch?v=CA3NUCMzkpc
542-
log: https://dps.report/iv40-20250624-172217_golem
539+
- author: Kadenar
540+
url: https://www.youtube.com/watch?v=1CnW1G_AB4c
541+
log: https://dps.report/lpOL-20251006-093317_golem
543542

544543
# currently exact copy of alacrity fire tempest (i.e. incorrectly ignoring transcendent tempest reduced overload cooldown)
545544
- name: '"Fire Wizard" (Approx.)'
@@ -632,7 +631,7 @@ list:
632631
profession: Catalyst
633632
value:
634633
{
635-
"values2": { "Power": 2463, "Power2": 0, "Burning": 8.61, "Bleeding": 23.3, "Poisoned": 0.15, "Torment": 0, "Confusion": 0 }
634+
"values2": { "Power": 2397, "Power2": 0, "Burning": 8.61, "Bleeding": 23.3, "Poisoned": 0.15, "Torment": 0, "Confusion": 0 }
636635
}
637636
credit:
638637
- author: Maragon
@@ -644,7 +643,7 @@ list:
644643
profession: Catalyst
645644
value:
646645
{
647-
"values2": { "Power": 2007, "Power2": 0, "Burning": 8.8, "Bleeding": 25.31, "Poisoned": 0, "Torment": 0, "Confusion": 0 }
646+
"values2": { "Power": 1953, "Power2": 0, "Burning": 8.8, "Bleeding": 25.31, "Poisoned": 0, "Torment": 0, "Confusion": 0 }
648647
}
649648
credit:
650649
- author: Kadenar

‎src/assets/presetdata/preset-extras.yaml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1933,7 +1933,7 @@ list:
19331933
"lifestealAmount": ""
19341934
}
19351935

1936-
- name: Power Tempest Bloodstone (Fractal)
1936+
- name: Power Tempest Inferno (Fractal)
19371937
profession: Tempest
19381938
value:
19391939
{
@@ -1949,8 +1949,8 @@ list:
19491949
"ranger": {}
19501950
},
19511951
"Relics": {
1952-
"bloodstone-relic": {
1953-
"amount": "0.6"
1952+
"fireworks-relic": {
1953+
"amount": "100"
19541954
}
19551955
},
19561956
"Sigil1": {
@@ -1979,7 +1979,7 @@ list:
19791979
"lifestealAmount": ""
19801980
}
19811981

1982-
- name: Power Tempest Bloodstone (Raid)
1982+
- name: Power Tempest Inferno (Raid)
19831983
profession: Tempest
19841984
value:
19851985
{
@@ -1995,8 +1995,8 @@ list:
19951995
"ranger": {}
19961996
},
19971997
"Relics": {
1998-
"bloodstone-relic": {
1999-
"amount": "0.6"
1998+
"fireworks-relic": {
1999+
"amount": "100"
20002000
}
20012001
},
20022002
"Sigil1": {

‎src/assets/presetdata/preset-traits.yaml‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4472,7 +4472,7 @@ list:
44724472
{
44734473
"skills": {
44744474
"signet-of-fire": {
4475-
"amount": "22"
4475+
"amount": ""
44764476
},
44774477
"signet-of-earth": {},
44784478
"ele-summon-dps": {
@@ -4728,13 +4728,13 @@ list:
47284728
"items": [
47294729
{
47304730
"empowering-flame": {
4731-
"amount": "68"
4731+
"amount": "70"
47324732
},
47334733
"burning-precision": {},
47344734
"burning-rage": {},
47354735
"power-overwhelming": {},
47364736
"power-overwhelming-2": {
4737-
"amount": "68"
4737+
"amount": "70"
47384738
},
47394739
"pyromancers-training": {},
47404740
"persisting-flames": {
@@ -4766,7 +4766,7 @@ list:
47664766
"gathered-focus": {},
47674767
"hardy-conduit": {},
47684768
"transcendent-tempest": {
4769-
"amount": "50"
4769+
"amount": "65"
47704770
},
47714771
"tempestuous-aria": {
47724772
"amount": ""
@@ -4778,7 +4778,10 @@ list:
47784778
{
47794779
"skills": {
47804780
"ele-summon-dps": {
4781-
"amount": "1278"
4781+
"amount": "1417"
4782+
},
4783+
"signet-of-fire": {
4784+
"amount": "20"
47824785
}
47834786
}
47844787
}
@@ -5717,7 +5720,7 @@ list:
57175720
{
57185721
"skills": {
57195722
"signet-of-fire": {
5720-
"amount": "13"
5723+
"amount": ""
57215724
},
57225725
"signet-of-earth": {},
57235726
"ele-summon-dps": {
@@ -5816,7 +5819,7 @@ list:
58165819
{
58175820
"skills": {
58185821
"signet-of-fire": {
5819-
"amount": "14"
5822+
"amount": ""
58205823
},
58215824
"signet-of-earth": {},
58225825
"ele-summon-dps": {
@@ -5913,7 +5916,7 @@ list:
59135916
"amount": "72.5"
59145917
},
59155918
"signet-of-fire": {
5916-
"amount": "12.6"
5919+
"amount": ""
59175920
}
59185921
}
59195922
}

‎src/assets/presetdata/templates.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,9 +1019,9 @@ list:
10191019
distribution: Power Tempest Inferno
10201020
traits: Power Tempest Inferno
10211021
fractal:
1022-
extras: Power Tempest Bloodstone (Fractal)
1022+
extras: Power Tempest Inferno (Fractal)
10231023
raid:
1024-
extras: Power Tempest Bloodstone (Raid)
1024+
extras: Power Tempest Inferno (Raid)
10251025
weaponType: Dual wield
10261026
outdated: false
10271027

@@ -1187,7 +1187,7 @@ list:
11871187
weaponType: Dual wield
11881188
outdated: false
11891189

1190-
- name: Condi Catalyst P/D Steamshrieker
1190+
- name: Condi Catalyst P/D Steamshrieker (Approx.)
11911191
id: condi-cat-pd
11921192
specialization: Catalyst
11931193
boonType: Condi

‎src/assets/testData.js‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -613,6 +613,23 @@ const testPresets = async () => {
613613
Object.keys(entry.skills.skills).forEach((id) =>
614614
gentleAssert(allTraitIds.has(id), `${entry.name} has nonexistent skill id: ${id}`),
615615
);
616+
617+
const { traits, skills } = entry;
618+
619+
const strengthOfStone = 275;
620+
if (traits.selectedTraits.some((arr) => arr.some((trait) => trait === strengthOfStone))) {
621+
gentleAssert(
622+
[undefined, '', '100'].includes(skills.skills['signet-of-fire']?.amount),
623+
`${entry.name} traits has Strength of Stone but partial fire signet uptime`,
624+
);
625+
}
626+
627+
if (entry.name.includes('Inferno')) {
628+
gentleAssert(
629+
![undefined, '', '100'].includes(skills.skills['signet-of-fire']?.amount),
630+
`${entry.name} traits has Inferno in the name but 100% fire signet uptime`,
631+
);
632+
}
616633
}
617634
if (type === 'distribution') {
618635
if (

0 commit comments

Comments
 (0)