From da3c86df7cb71399e4fa9c122f46aa42a987bf20 Mon Sep 17 00:00:00 2001 From: marcustyphoon Date: Wed, 17 Dec 2025 07:27:15 -0800 Subject: [PATCH 1/6] check for erroneous fire signet amounts --- src/assets/testData.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/assets/testData.js b/src/assets/testData.js index 4b84e4419..689624b6f 100644 --- a/src/assets/testData.js +++ b/src/assets/testData.js @@ -613,6 +613,16 @@ const testPresets = async () => { Object.keys(entry.skills.skills).forEach((id) => gentleAssert(allTraitIds.has(id), `${entry.name} has nonexistent skill id: ${id}`), ); + + const { traits, skills } = entry; + + const strengthOfStone = 275; + if (traits.selectedTraits.some((arr) => arr.some((trait) => trait === strengthOfStone))) { + gentleAssert( + [undefined, '', '100'].includes(skills.skills['signet-of-fire']?.amount), + `${entry.name} traits has Strength of Stone but partial fire signet uptime`, + ); + } } if (type === 'distribution') { if ( From 30e804d43f7383eec6463a25dc6c895a5735968a Mon Sep 17 00:00:00 2001 From: marcustyphoon Date: Wed, 17 Dec 2025 07:29:24 -0800 Subject: [PATCH 2/6] check for more erroneous fire signet amounts --- src/assets/testData.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/assets/testData.js b/src/assets/testData.js index 689624b6f..670b85414 100644 --- a/src/assets/testData.js +++ b/src/assets/testData.js @@ -623,6 +623,13 @@ const testPresets = async () => { `${entry.name} traits has Strength of Stone but partial fire signet uptime`, ); } + + if (entry.name.includes('Inferno')) { + gentleAssert( + ![undefined, '', '100'].includes(skills.skills['signet-of-fire']?.amount), + `${entry.name} traits has Inferno in the name but 100% fire signet uptime`, + ); + } } if (type === 'distribution') { if ( From ee18fb14d64bdb48c076d7306252a4df66e9e426 Mon Sep 17 00:00:00 2001 From: marcustyphoon Date: Wed, 17 Dec 2025 12:13:11 -0800 Subject: [PATCH 3/6] fix Alacrity Condi Tempest Scepter --- src/assets/presetdata/preset-distribution.yaml | 2 +- src/assets/presetdata/preset-traits.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/assets/presetdata/preset-distribution.yaml b/src/assets/presetdata/preset-distribution.yaml index f8d22b949..f6969939f 100644 --- a/src/assets/presetdata/preset-distribution.yaml +++ b/src/assets/presetdata/preset-distribution.yaml @@ -489,7 +489,7 @@ list: profession: Tempest value: { - "values2": { "Power": 2657, "Power2": 0, "Burning": 10.65, "Bleeding": 19.24, "Poisoned": 0, "Torment": 0, "Confusion": 0 } + "values2": { "Power": 2588, "Power2": 0, "Burning": 10.65, "Bleeding": 19.24, "Poisoned": 0, "Torment": 0, "Confusion": 0 } } credit: - author: '[NA] Crone' diff --git a/src/assets/presetdata/preset-traits.yaml b/src/assets/presetdata/preset-traits.yaml index dc069565a..90d1e240b 100644 --- a/src/assets/presetdata/preset-traits.yaml +++ b/src/assets/presetdata/preset-traits.yaml @@ -4472,7 +4472,7 @@ list: { "skills": { "signet-of-fire": { - "amount": "22" + "amount": "" }, "signet-of-earth": {}, "ele-summon-dps": { From 97afedbfb725a40f5ad1041e57fc01c4bde6bf84 Mon Sep 17 00:00:00 2001 From: marcustyphoon Date: Wed, 17 Dec 2025 12:18:45 -0800 Subject: [PATCH 4/6] fix Condi Catalyst P/D Steamshrieker --- locales/en/translation.json | 2 +- src/assets/presetdata/preset-distribution.yaml | 2 +- src/assets/presetdata/preset-traits.yaml | 4 ++-- src/assets/presetdata/templates.yaml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/locales/en/translation.json b/locales/en/translation.json index fc5d5fbc0..0cadf085f 100644 --- a/locales/en/translation.json +++ b/locales/en/translation.json @@ -379,7 +379,7 @@ "buildTemplateName_Condi Barrier \"Carrion\" Specter SC/D": "Condi Barrier \"Carrion\" Specter SC/D", "buildTemplateName_Condi Berserker Blademaster": "Condi Berserker Blademaster", "buildTemplateName_Condi Berserker UF": "Condi Berserker UF", - "buildTemplateName_Condi Catalyst P/D Steamshrieker": "Condi Catalyst P/D Steamshrieker", + "buildTemplateName_Condi Catalyst P/D Steamshrieker (Approx.)": "Condi Catalyst P/D Steamshrieker (Approx.)", "buildTemplateName_Condi Chrono Scepter": "Condi Chrono Scepter", "buildTemplateName_Condi Chrono Staff SC/D (Approx.)": "Condi Chrono Staff SC/D (Approx.)", "buildTemplateName_Condi Daredevil": "Condi Daredevil", diff --git a/src/assets/presetdata/preset-distribution.yaml b/src/assets/presetdata/preset-distribution.yaml index f6969939f..57d083da5 100644 --- a/src/assets/presetdata/preset-distribution.yaml +++ b/src/assets/presetdata/preset-distribution.yaml @@ -632,7 +632,7 @@ list: profession: Catalyst value: { - "values2": { "Power": 2463, "Power2": 0, "Burning": 8.61, "Bleeding": 23.3, "Poisoned": 0.15, "Torment": 0, "Confusion": 0 } + "values2": { "Power": 2397, "Power2": 0, "Burning": 8.61, "Bleeding": 23.3, "Poisoned": 0.15, "Torment": 0, "Confusion": 0 } } credit: - author: Maragon diff --git a/src/assets/presetdata/preset-traits.yaml b/src/assets/presetdata/preset-traits.yaml index 90d1e240b..41d849db8 100644 --- a/src/assets/presetdata/preset-traits.yaml +++ b/src/assets/presetdata/preset-traits.yaml @@ -5717,7 +5717,7 @@ list: { "skills": { "signet-of-fire": { - "amount": "13" + "amount": "" }, "signet-of-earth": {}, "ele-summon-dps": { @@ -5816,7 +5816,7 @@ list: { "skills": { "signet-of-fire": { - "amount": "14" + "amount": "" }, "signet-of-earth": {}, "ele-summon-dps": { diff --git a/src/assets/presetdata/templates.yaml b/src/assets/presetdata/templates.yaml index df28bf429..887dc6001 100644 --- a/src/assets/presetdata/templates.yaml +++ b/src/assets/presetdata/templates.yaml @@ -1187,7 +1187,7 @@ list: weaponType: Dual wield outdated: false - - name: Condi Catalyst P/D Steamshrieker + - name: Condi Catalyst P/D Steamshrieker (Approx.) id: condi-cat-pd specialization: Catalyst boonType: Condi From ec53bed47c28da7103bf337a0084a549e6a643c4 Mon Sep 17 00:00:00 2001 From: marcustyphoon Date: Wed, 17 Dec 2025 12:20:28 -0800 Subject: [PATCH 5/6] fix Condi Catalyst P/W --- src/assets/presetdata/preset-distribution.yaml | 2 +- src/assets/presetdata/preset-traits.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/assets/presetdata/preset-distribution.yaml b/src/assets/presetdata/preset-distribution.yaml index 57d083da5..f194c9d26 100644 --- a/src/assets/presetdata/preset-distribution.yaml +++ b/src/assets/presetdata/preset-distribution.yaml @@ -644,7 +644,7 @@ list: profession: Catalyst value: { - "values2": { "Power": 2007, "Power2": 0, "Burning": 8.8, "Bleeding": 25.31, "Poisoned": 0, "Torment": 0, "Confusion": 0 } + "values2": { "Power": 1953, "Power2": 0, "Burning": 8.8, "Bleeding": 25.31, "Poisoned": 0, "Torment": 0, "Confusion": 0 } } credit: - author: Kadenar diff --git a/src/assets/presetdata/preset-traits.yaml b/src/assets/presetdata/preset-traits.yaml index 41d849db8..5122608c0 100644 --- a/src/assets/presetdata/preset-traits.yaml +++ b/src/assets/presetdata/preset-traits.yaml @@ -5913,7 +5913,7 @@ list: "amount": "72.5" }, "signet-of-fire": { - "amount": "12.6" + "amount": "" } } } From c17666d64772b58199473912fb09cfa48e1bb70b Mon Sep 17 00:00:00 2001 From: marcustyphoon Date: Wed, 17 Dec 2025 12:30:00 -0800 Subject: [PATCH 6/6] update Power Tempest Inferno --- locales/en/translation.json | 4 ++-- src/assets/presetdata/preset-distribution.yaml | 9 ++++----- src/assets/presetdata/preset-extras.yaml | 12 ++++++------ src/assets/presetdata/preset-traits.yaml | 11 +++++++---- src/assets/presetdata/templates.yaml | 4 ++-- 5 files changed, 21 insertions(+), 19 deletions(-) diff --git a/locales/en/translation.json b/locales/en/translation.json index 0cadf085f..be2f33cd1 100644 --- a/locales/en/translation.json +++ b/locales/en/translation.json @@ -897,8 +897,8 @@ "preset_extra_Power Quickness Herald (Raid)": "Power Quickness Herald (Raid)", "preset_extra_Power Quickness Untamed (Raid)": "Power Quickness Untamed (Raid)", "preset_extra_Power Staff Daredevil": "Power Staff Daredevil", - "preset_extra_Power Tempest Bloodstone (Fractal)": "Power Tempest Bloodstone (Fractal)", - "preset_extra_Power Tempest Bloodstone (Raid)": "Power Tempest Bloodstone (Raid)", + "preset_extra_Power Tempest Inferno (Fractal)": "Power Tempest Inferno (Fractal)", + "preset_extra_Power Tempest Inferno (Raid)": "Power Tempest Inferno (Raid)", "preset_extra_Power Weaver (Raid)": "Power Weaver (Raid)", "preset_extra_Power Willbender Virtues (Fractal)": "Power Willbender Virtues (Fractal)", "preset_extra_Quickness Condi Deadeye Spear": "Quickness Condi Deadeye Spear", diff --git a/src/assets/presetdata/preset-distribution.yaml b/src/assets/presetdata/preset-distribution.yaml index f194c9d26..51d1fb162 100644 --- a/src/assets/presetdata/preset-distribution.yaml +++ b/src/assets/presetdata/preset-distribution.yaml @@ -529,17 +529,16 @@ list: url: https://www.youtube.com/watch?v=50-VmnennEs log: https://dps.report/0kW0-20251120-143549_golem - # use bloodstone-relic-prenerf-2 if resimulating - name: Power Tempest Inferno profession: Tempest value: { - "values2": { "Power": 3795, "Power2": 0, "Burning": 10.68, "Bleeding": 4.54, "Poisoned": 0, "Torment": 0, "Confusion": 0 } + "values2": { "Power": 3685, "Power2": 0, "Burning": 10.5, "Bleeding": 4.37, "Poisoned": 0, "Torment": 0, "Confusion": 0 } } credit: - - author: '[NA] Crone' - url: https://www.youtube.com/watch?v=CA3NUCMzkpc - log: https://dps.report/iv40-20250624-172217_golem + - author: Kadenar + url: https://www.youtube.com/watch?v=1CnW1G_AB4c + log: https://dps.report/lpOL-20251006-093317_golem # currently exact copy of alacrity fire tempest (i.e. incorrectly ignoring transcendent tempest reduced overload cooldown) - name: '"Fire Wizard" (Approx.)' diff --git a/src/assets/presetdata/preset-extras.yaml b/src/assets/presetdata/preset-extras.yaml index de4871857..8820ce09a 100644 --- a/src/assets/presetdata/preset-extras.yaml +++ b/src/assets/presetdata/preset-extras.yaml @@ -1933,7 +1933,7 @@ list: "lifestealAmount": "" } - - name: Power Tempest Bloodstone (Fractal) + - name: Power Tempest Inferno (Fractal) profession: Tempest value: { @@ -1949,8 +1949,8 @@ list: "ranger": {} }, "Relics": { - "bloodstone-relic": { - "amount": "0.6" + "fireworks-relic": { + "amount": "100" } }, "Sigil1": { @@ -1979,7 +1979,7 @@ list: "lifestealAmount": "" } - - name: Power Tempest Bloodstone (Raid) + - name: Power Tempest Inferno (Raid) profession: Tempest value: { @@ -1995,8 +1995,8 @@ list: "ranger": {} }, "Relics": { - "bloodstone-relic": { - "amount": "0.6" + "fireworks-relic": { + "amount": "100" } }, "Sigil1": { diff --git a/src/assets/presetdata/preset-traits.yaml b/src/assets/presetdata/preset-traits.yaml index 5122608c0..9fef1b29e 100644 --- a/src/assets/presetdata/preset-traits.yaml +++ b/src/assets/presetdata/preset-traits.yaml @@ -4728,13 +4728,13 @@ list: "items": [ { "empowering-flame": { - "amount": "68" + "amount": "70" }, "burning-precision": {}, "burning-rage": {}, "power-overwhelming": {}, "power-overwhelming-2": { - "amount": "68" + "amount": "70" }, "pyromancers-training": {}, "persisting-flames": { @@ -4766,7 +4766,7 @@ list: "gathered-focus": {}, "hardy-conduit": {}, "transcendent-tempest": { - "amount": "50" + "amount": "65" }, "tempestuous-aria": { "amount": "" @@ -4778,7 +4778,10 @@ list: { "skills": { "ele-summon-dps": { - "amount": "1278" + "amount": "1417" + }, + "signet-of-fire": { + "amount": "20" } } } diff --git a/src/assets/presetdata/templates.yaml b/src/assets/presetdata/templates.yaml index 887dc6001..786070157 100644 --- a/src/assets/presetdata/templates.yaml +++ b/src/assets/presetdata/templates.yaml @@ -1019,9 +1019,9 @@ list: distribution: Power Tempest Inferno traits: Power Tempest Inferno fractal: - extras: Power Tempest Bloodstone (Fractal) + extras: Power Tempest Inferno (Fractal) raid: - extras: Power Tempest Bloodstone (Raid) + extras: Power Tempest Inferno (Raid) weaponType: Dual wield outdated: false