chore: appease golangci and run CI on pull requests (#479)

Author: davfsa

.github/workflows/go.yml

@@ -1,15 +1,26 @@
 name: Go
 
 on:
+  pull_request:
+    paths:
+      - '**/*.go'
+      - '**/go.mod'
+      - '**/go.sum'
+      - '.github/workflows/go.yml'
+
   push:
     paths:
       - '**/*.go'
       - '**/go.mod'
       - '**/go.sum'
       - '.github/workflows/go.yml'
 
+
+# The if of each job prevents running the workflow if it's from a pull request from the directory the pull request is targeted towards
+# as it will already run on 'push'
 jobs:
   build:
+    if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) }}
     runs-on: ubuntu-latest
     steps:
       - uses: actions/setup-go@v5
@@ -20,6 +31,7 @@ jobs:
         run: go build -v ./...
 
   test:
+    if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) }}
     runs-on: ubuntu-latest
     steps:
       - uses: actions/setup-go@v5
@@ -30,6 +42,7 @@ jobs:
         run: go test -v ./...
 
   golangci:
+    if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) }}
     runs-on: ubuntu-latest
     steps:
       - uses: actions/setup-go@v5

gateway/gateway_transports.go

@@ -135,10 +135,9 @@ func (r *pipeBuffer) Read(p []byte) (int, error) {
 }
 
 // Write appends the contents of p to the buffer, growing the buffer as
-// needed. The return value n is the length of p; err is always nil. If the
-// buffer becomes too large, Write will panic with [ErrTooLarge].
-func (r *pipeBuffer) Write(p []byte) (int, error) {
-	return r.buffer.Write(p)
+// needed. If the buffer becomes too large, Write will panic with [ErrTooLarge].
+func (r *pipeBuffer) Write(p []byte) {
+	_, _ = r.buffer.Write(p)
 }
 
 // Reset resets the buffer to be empty, but it retains the underlying