Consistent use of = as equality operator in tests

Also fix some quoting in these tests.

Author: ndokos

agent/bench-scripts/pbench-fio

@@ -141,6 +141,7 @@ function fio_usage() {
 
 function fio_process_options() {
 	opts=$(getopt -q -o jic:t:b:s:d:r: --longoptions "help,max-stddev:,max-failures:,samples:,direct:,sync:,install,remote-only,clients:,client-file:,iodepth:,ioengine:,config:,jobs-per-dev:,job-mode:,rate-iops:,ramptime:,runtime:,test-types:,block-sizes:,file-size:,targets:,tool-group:,postprocess-only:,run-dir:,directory:,numjobs:,job-file:" -n "getopt.sh" -- "$@");
+
 	if [ $? -ne 0 ]; then
 		printf "\t${benchmark}: you specified an invalid option\n\n"
 		fio_usage
@@ -366,7 +367,7 @@ function fio_process_options() {
 			;;
 		esac
 	done
-	if [ $postprocess_only == "n" ]; then
+	if [ "$postprocess_only" = "n" ]; then
 		benchmark_run_dir="$pbench_run/${benchmark}_${config}_$date"
 	else
 		if [ -z "$run_dir" ]; then
@@ -382,7 +383,7 @@ function fio_process_options() {
 
 # Ensure the right version of the benchmark is installed
 function fio_install() {
-	if [ "$postprocess_only" == "n" ]; then
+	if [ "$postprocess_only" = "n" ]; then
 		if check_install_rpm $benchmark_rpm $ver; then
 			debug_log "[$script_name]$benchmark_rpm $ver is installed"
 		else
@@ -403,7 +404,7 @@ function fio_install() {
 
 # install python-pandas on the controller: fiologparser_hist.py needs it
 function pandas_install() {
-	if [ "$postprocess_only" == "n" ]; then
+	if [ "$postprocess_only" = "n" ]; then
 		if check_install_rpm python-pandas; then
 			debug_log "[$script_name]python-pandas is installed"
 		else
@@ -420,7 +421,7 @@ function print_iteration {
 	printf "\n%28s" "$1" >>$benchmark_summary_txt_file
 	printf "\n%s" "$1" >>$benchmark_summary_csv_file
 	hists=`cat $iteration_dir/reference-result/fio.job 2>/dev/null | grep "^log_hist_msec"`
-	if [ $1 == "iteration" ]; then
+	if [ "$1" = "iteration" ]; then
 		# this is just a label, so no links here
 		if [ ! -z "$hist_interval" ]; then
 			printf "\n%28s %s %s %s" "iteration" "summary" "hist-results" "tools">>$benchmark_summary_html_file
@@ -461,7 +462,7 @@ function fio_device_check() {
 	local dev=""
 	local client=""
 	local rc=0
-	if [ "$postprocess_only" == "n" ]; then
+	if [ "$postprocess_only" = "n" ]; then
 		debug_log "fio_device_check() $devs $clients"
 		for dev in `echo $devs | sed -e s/,/" "/g`; do
 			if echo $dev | grep -q "^/dev/"; then
@@ -643,7 +644,7 @@ function fio_run_benchmark() {
 						echo "Restarting iteration $iteration ($count of $total_iterations)"
 						log "Restarting iteration $iteration ($count of $total_iterations)"
 					fi
-					if [ "$postprocess_only" == "n" ]; then
+					if [ "$postprocess_only" = "n" ]; then
 						mkdir -p $iteration_dir
 					else
 						if [ ! -e $iteration_dir ]; then
@@ -678,7 +679,7 @@ function fio_run_benchmark() {
 							fi
 							benchmark_results_dir="$iteration_dir/sample$sample"
 							benchmark_tools_dir="$benchmark_results_dir/tools-$tool_group"
-							if [ "$postprocess_only" == "n" ]; then
+							if [ "$postprocess_only" = "n" ]; then
 								mkdir -p $benchmark_results_dir
 								fio_job_file="$benchmark_results_dir/fio.job"
 								fio_create_jobfile "$test_type" "$ioengine" "$block_size" "$iodepth" "$direct" "$sync" "$runtime" "$ramptime" "$file_size" "$rate_iops" "$dev" "$fio_job_file"
@@ -776,11 +777,11 @@ function fio_run_benchmark() {
 								else
 									# delete the tool data [and respose time log for rr tests] from the other samples to save space
 									# this option is off by default
-									if [ "$keep_failed_tool_data" == "n" ]; then
+									if [ "$keep_failed_tool_data" = "n" ]; then
 										/bin/rm -rf $iteration_dir/$sample_dir/tools-* $iteration_dir/$sample_dir/response-times.txt
 									fi
 									# since non reference-result sample data is rarely referenced, tar it up to reduce the number of files used
-									if [ "$tar_nonref_data" == "y" ]; then
+									if [ "$tar_nonref_data" = "y" ]; then
 										pushd "$iteration_dir" >/dev/null; tar --create --xz --force-local --file=$sample_dir.tar.xz $sample_dir && /bin/rm -rf $sample_dir; popd >/dev/null
 									fi
 								fi
@@ -873,7 +874,7 @@ fio_install
 if [ "$remote_only" = "n" ] ;then
 	pandas_install
 fi
-if [ "$install_only" == "y" ]; then
+if [ "$install_only" = "y" ]; then
 	exit 0
 fi