Rework pbench-agent ansible playbooks

Rework the ansible playbooks to make them as similar as possible to
the server ansible playbooks (PR#1199). In particular, fix the config
and ssh key install to allow hosts outside the firewall to be
configured (as long as the ansible host is inside).

Usage:

     ansible-playbook --user=root -i /path/to/inventory.file \
                      pbench-agent-install.yml \
                      [ --extra-vars='{cenv: <environment>}' ]

Two other playbooks use subsets of the defined roles:
pbench-repo-install.yml installs the COPR repos only. You can then
install the pbench-agent RPM manually.  In that case, the third
playbook can be used to install the config and key files afterwards.

An example inventory file, Inventory/pbench-agent.hosts.example, is
provided. The second section of the file contains the definition of
various variables that are used by the playbooks.  These are set to
dummy values here, so a site admin should modify this file for a
particular installation and make it available to the users for that
site.

Users should then copy and mofify the example file, without touching
the variables section: they should just add their hosts to the first
section (possibly augmented with host varirable definitions,
e.g. ansible_python_interpreter, that might be need to work around
problems on some distros).

Author: ndokos

agent/ansible/Inventory/pbench-agent.hosts

@@ -0,0 +1,31 @@
+# Users should copy the site-specific file and modify *only* the
+# first section by adding their hosts. They may also need to
+# provide host-specific variables to deal with problems (e.g ATM,
+# a F30 host needs to have the `ansible_python_interpreter' variable
+# to /usr/bin/python3 in order for things to work - see host3 below
+# as an example.)
+[servers]
+host1
+host2
+host3       ansible_python_interpreter=/usr/bin/python3
+
+# This section contains site-specific variables. An admin should
+# modify these settings and provide the resulting file as a site-specific
+# example. Once that is done, users should *NOT* have to modify this section at all.
+[servers:vars]
+pbench_repo_url_prefix = https://copr-be.cloud.fedoraproject.org/results/<EXAMPLE_USER>
+
+# where to get the key
+pbench_key_url = http://EXAMPLE.COM/PATH/TO/agent/{{ cenv }}/ssh
+# where to put it
+pbench_key_dest = /opt/pbench-agent/
+
+# where to get the config file
+pbench_config_url = http://EXAMPLE.COM/PATH/TO/agent/{{ cenv }}/config
+# where to put it
+pbench_config_dest = /opt/pbench-agent/config/
+
+pbench_config_files = '["pbench-agent.cfg"]'
+
+owner = pbench
+group = pbench

agent/ansible/Inventory/pbench-agent.hosts.example

@@ -1,16 +1,26 @@
-* Ansible playbook to install key and config file
+* Ansible playbooks to install pbench-agent
 
-We assume that the pbench-agent code has been installed (through a
-package or some other method). That installation is incomplete until
-we install a key file so that =pbench=-move/copy-results= can
-move/copy results to the server and a config file so that it knows
-which server to use.
+The basic playbook is pbench-agent-install.yml which
 
-The =pbench-agent-config.yml= playbook does that, by using variables
-defined in the inventory file (for an example inventory file, see
-=Inventory/pbench-agent.hosts=).
+  - installs the pbench agent repo.
+  - installs the pbench-agent RPM.
+  - installs the config file(s)
+  - installs the ssh key file.
+
+Two other playbooks are subsets of this one: pbench-repo-install.yml
+performs the first step only; pbench-agent-config.yml performs the
+last two steps only.
+
+N.B. Installation is incomplete until we install a key file so that
+=pbench=-move/copy-results= can move/copy results to the server and a
+config file so that it knows which server to use.
+
+The playbooks use variables defined in the inventory file (for an
+example inventory file, see =Inventory/pbench-agent.hosts.example=).
+It must be modified for a given environment: see comments in the
+file for guidance.
 
 * Usage
 #+begin_src shell
-ansible-playbook -i Inventory/pbench-agent.hosts pbench-agent-config.yml
+ansible-playbook -i /path/to/inventory/pbench-agent.hosts pbench-agent-install.yml
 #+end_src

agent/ansible/README

@@ -1,10 +1,11 @@
 ---
-- name: install pbench.repo
+- name: install pbench-agent config and key files
   hosts: servers
   remote_user: root
   become: yes
   become_user: root
 
   roles:
-      - pbench-agent-install-key
-      - pbench-agent-install-config
+    - pbench-agent-config-install
+    - pbench-agent-key-install
+

agent/ansible/pbench-agent-config.yml

@@ -0,0 +1,13 @@
+---
+- name: install pbench-agent
+  hosts: servers
+  remote_user: root
+  become: yes
+  become_user: root
+
+  roles:
+    - pbench-repo-install
+    - pbench-agent-install
+    - pbench-agent-config-install
+    - pbench-agent-key-install
+

agent/ansible/pbench-agent-install.yml

@@ -0,0 +1,10 @@
+---
+- name: install pbench-agent repo
+  hosts: servers
+  remote_user: root
+  become: yes
+  become_user: root
+
+  roles:
+    - pbench-repo-install
+

agent/ansible/pbench-repo-install.yml

@@ -0,0 +1,5 @@
+---
+pbench_agent_install_dir: /opt/pbench-agent
+pbench_agent_config_dest: "{{ pbench_agent_install_dir }}/config"
+pbench_owner: pbench
+pbench_group: pbench

agent/ansible/roles/pbench-agent-config-install/defaults/main.yml

@@ -0,0 +1,37 @@
+---
+# Install config file for pbench agent.
+
+- name: create temp dir to store the config locally
+  delegate_to: localhost
+  tempfile:
+    state: directory
+    prefix: "{{ inventory_hostname }}-"
+  register: tempdir_1
+
+- name: relax perms
+  delegate_to: localhost
+  file:
+    path: "{{ tempdir_1.path }}"
+    mode: 0755
+
+- name: install the config file(s) locally
+  delegate_to: localhost
+  get_url:
+    url: "{{ pbench_config_url }}/{{ item }}"
+    dest: "{{ tempdir_1.path }}/{{ item }}"
+  with_items: "{{ pbench_config_files }}"
+
+- name: copy the config file(s) to the remote
+  copy:
+    src:  "{{ tempdir_1.path }}/{{ item }}"
+    dest: "{{ pbench_config_dest }}"
+    mode: 0644
+    owner: root
+    group: root
+  with_items: "{{ pbench_config_files }}"
+
+- name: delete local temp dir
+  delegate_to: localhost
+  file:
+    state: absent
+    path: "{{ tempdir_1.path }}"