Skip to content

Commit cbef546

Browse files
authored
Merge pull request #491 from ndokos/wip-record-iterations
Record iterations
2 parents 5f646e2 + fc479c4 commit cbef546

37 files changed

+250
-106
lines changed

agent/base

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,9 @@ function debug_log {
8383
# Some standard global vars - try the config file first and fall back on hardwired defaults
8484
# which are valid today.
8585
if [[ -z "$_PBENCH_BENCH_TESTS" ]]; then
86-
date=`date --utc "+%F_%H:%M:%S"`
86+
if [ -z "$date" ] ;then
87+
export date=`date --utc "+%F_%H:%M:%S"`
88+
fi
8789
hostname=`hostname -s`
8890
full_hostname=`hostname`
8991
else

agent/bench-scripts/gold/pbench-dbench/test-02.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ Iteration 2-48thread complete (2 of 2), with 1 pass and 0 failures
9494
/var/tmp/pbench-test-bench/pbench/dbench__1900-01-01_00:00:00/summary-result.txt
9595
/var/tmp/pbench-test-bench/pbench/pbench.log
9696
/var/tmp/pbench-test-bench/pbench/tmp
97+
/var/tmp/pbench-test-bench/pbench/tmp/dbench__1900-01-01_00:00:00.iterations
9798
/var/tmp/pbench-test-bench/pbench/tools-default
9899
/var/tmp/pbench-test-bench/pbench/tools-default/mpstat
99100
/var/tmp/pbench-test-bench/pbench/tools-default/sar

agent/bench-scripts/gold/pbench-fio/test-04.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1105,6 +1105,7 @@ Iteration 6-randrw-1024KiB complete (6 of 6), with 1 pass and 6 failures
11051105
/var/tmp/pbench-test-bench/pbench/fio__1900-01-01_00:00:00/summary-result.txt
11061106
/var/tmp/pbench-test-bench/pbench/pbench.log
11071107
/var/tmp/pbench-test-bench/pbench/tmp
1108+
/var/tmp/pbench-test-bench/pbench/tmp/fio__1900-01-01_00:00:00.iterations
11081109
/var/tmp/pbench-test-bench/pbench/tools-default
11091110
/var/tmp/pbench-test-bench/pbench/tools-default/mpstat
11101111
/var/tmp/pbench-test-bench/pbench/tools-default/sar

agent/bench-scripts/gold/pbench-fio/test-05.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -561,6 +561,7 @@ Iteration 3-throughput-1024KiB complete (3 of 3), with 1 pass and 6 failures
561561
/var/tmp/pbench-test-bench/pbench/fio__1900-01-01_00:00:00/summary-result.txt
562562
/var/tmp/pbench-test-bench/pbench/pbench.log
563563
/var/tmp/pbench-test-bench/pbench/tmp
564+
/var/tmp/pbench-test-bench/pbench/tmp/fio__1900-01-01_00:00:00.iterations
564565
/var/tmp/pbench-test-bench/pbench/tools-default
565566
/var/tmp/pbench-test-bench/pbench/tools-default/mpstat
566567
/var/tmp/pbench-test-bench/pbench/tools-default/sar

agent/bench-scripts/gold/pbench-fio/test-06.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -562,6 +562,7 @@ Iteration 3-throughput-1024KiB complete (3 of 3), with 1 pass and 6 failures
562562
/var/tmp/pbench-test-bench/pbench/fio__1900-01-01_00:00:00/summary-result.txt
563563
/var/tmp/pbench-test-bench/pbench/pbench.log
564564
/var/tmp/pbench-test-bench/pbench/tmp
565+
/var/tmp/pbench-test-bench/pbench/tmp/fio__1900-01-01_00:00:00.iterations
565566
/var/tmp/pbench-test-bench/pbench/tools-default
566567
/var/tmp/pbench-test-bench/pbench/tools-default/mpstat
567568
/var/tmp/pbench-test-bench/pbench/tools-default/sar

agent/bench-scripts/gold/pbench-moongen/test-03.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ Iteration 4-throughput-unidirec-1024B-1024flows-1pct_drop complete (4 of 4), wit
7676
/var/tmp/pbench-test-bench/pbench/moongen__1900-01-01_00:00:00/pbench-moongen.cmd
7777
/var/tmp/pbench-test-bench/pbench/pbench.log
7878
/var/tmp/pbench-test-bench/pbench/tmp
79+
/var/tmp/pbench-test-bench/pbench/tmp/moongen__1900-01-01_00:00:00.iterations
7980
/var/tmp/pbench-test-bench/pbench/tools-default
8081
/var/tmp/pbench-test-bench/pbench/tools-default/mpstat
8182
/var/tmp/pbench-test-bench/pbench/tools-default/sar

agent/bench-scripts/gold/pbench-uperf/test-00.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ Iteration 2-tcp_stream-64B-1i complete (2 of 2), with 1 pass and 0 failures
1717
/var/tmp/pbench-test-bench/pbench
1818
/var/tmp/pbench-test-bench/pbench/pbench.log
1919
/var/tmp/pbench-test-bench/pbench/tmp
20+
/var/tmp/pbench-test-bench/pbench/tmp/uperf_test-00_1900-01-01_00:00:00.iterations
2021
/var/tmp/pbench-test-bench/pbench/tools-default
2122
/var/tmp/pbench-test-bench/pbench/tools-default/mpstat
2223
/var/tmp/pbench-test-bench/pbench/tools-default/sar

agent/bench-scripts/gold/pbench-uperf/test-01.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ Iteration 2-tcp_stream-64B-1i complete (2 of 2), with 1 pass and 0 failures
2525
/var/tmp/pbench-test-bench/pbench
2626
/var/tmp/pbench-test-bench/pbench/pbench.log
2727
/var/tmp/pbench-test-bench/pbench/tmp
28+
/var/tmp/pbench-test-bench/pbench/tmp/uperf_test-01_1900-01-01_00:00:00.iterations
2829
/var/tmp/pbench-test-bench/pbench/tools-default
2930
/var/tmp/pbench-test-bench/pbench/tools-default/mpstat
3031
/var/tmp/pbench-test-bench/pbench/tools-default/sar

agent/bench-scripts/pbench-cyclictest

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,9 @@ if [[ $? -ne 0 ]]; then
104104
exit 1
105105
fi
106106

107-
benchmark_run_dir="$pbench_run/${benchmark}_${config}_$date"
107+
benchmark_fullname="${benchmark}_${config}_${date}"
108+
benchmark_run_dir="$pbench_run/${benchmark_fullname}"
109+
benchmark_iterations="$pbench_tmp/${benchmark_fullname}.iterations"
108110
benchmark_summary_txt_file="$benchmark_run_dir/$benchmark-summary.txt"
109111
benchmark_summary_html_file="$benchmark_run_dir/$benchmark-summary.html"
110112
if [ ! -z "$cpu" ]; then
@@ -137,6 +139,7 @@ for runtime in `echo $runtimes | sed -e s/,/" "/g`; do
137139
if [ ! -z "$cpu" ]; then
138140
iteration="$iteration-cpu_$cpu"
139141
fi
142+
echo $iteration >> $benchmark_iterations
140143
benchmark_results_dir="$benchmark_run_dir/$iteration/reference-result/"
141144
result_file=$benchmark_results_dir/result.txt
142145
benchmark_cmd_file=$benchmark_results_dir/cyclictest.cmd

agent/bench-scripts/pbench-dbench

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,14 +240,17 @@ while true; do
240240
done
241241
if [[ -z "$benchmark_run_dir" ]]; then
242242
# We don't have an explicit run directory, construct one
243-
benchmark_run_dir="$pbench_run/${benchmark}_${config}_$date"
243+
benchmark_fullname="${benchmark}_${config}_${date}"
244+
benchmark_run_dir="$pbench_run/${benchmark_fullname}"
244245
else
245246
# We have an explicit run directory provided by --run-dir, so warn
246247
# the user if they also used --config
247248
if [[ ! -z "$config" ]]; then
248249
warn_log "[$script_name] ignoring --config=\"$config\" in favor of --rundir=\"$benchmark_run_dir\""
249250
fi
251+
benchmark_fullname="$(basename $benchmark_run_dir)"
250252
fi
253+
benchmark_iterations="$pbench_tmp/${benchmark_fullname}.iterations"
251254

252255
if [ -z "$clients" ]; then
253256
clients=127.0.0.1
@@ -304,6 +307,7 @@ for thread_count in `echo $thread_counts | sed -e s/,/" "/g`; do
304307
echo "Starting iteration $iteration ($count of $total_iterations)"
305308
log "Starting iteration $iteration ($count of $total_iterations)"
306309
iteration="${count}-${thread_count}thread"
310+
echo $iteration >> $benchmark_iterations
307311
iteration_dir="$benchmark_run_dir/$iteration"
308312
result_stddevpct=$maxstddevpct # this test case will get a "do-over" if the stddev is not low enough
309313
failures=0

0 commit comments

Comments
 (0)