Use new go:build and add test target to mage

Author: hslatman

.github/workflows/go.yml

@@ -32,7 +32,10 @@ jobs:
           go-version: 1.24 # TODO: matrix
 
       - name: Test
-        run: go test -v -race ./...
+        uses: magefile/mage-action@6f50bbb8ea47d56e62dee92392788acbc8192d0b # v3.1.0
+        with:
+          version: latest
+          args: test
 
   check:
     runs-on: ubuntu-latest

fakedb_test.go

@@ -194,6 +194,7 @@ type fakeConn struct {
 	called          bool // nolint:structcheck // ignore unused warning, it is accessed via reflection
 	rowsCloseCalled bool
 	stmt            driver.Stmt
+	queryStmt       driver.StmtQueryContext
 	tx              driver.Tx
 }
 
@@ -221,17 +222,12 @@ func (c *fakeConn) Close() error { return nil }
 
 func (c *fakeConn) Begin() (driver.Tx, error) { return c.tx, nil }
 
-func (c *fakeConn) QueryContext(_ context.Context, _ string, nvs []driver.NamedValue) (driver.Rows, error) {
-	if c.stmt == nil {
+func (c *fakeConn) QueryContext(ctx context.Context, _ string, nvs []driver.NamedValue) (driver.Rows, error) {
+	if c.queryStmt == nil {
 		return &fakeRows{con: c}, nil
 	}
 
-	var args []driver.Value
-	for _, nv := range nvs {
-		args = append(args, nv.Value)
-	}
-
-	return c.stmt.Query(args)
+	return c.queryStmt.QueryContext(ctx, nvs)
 }
 
 func (c *fakeConnWithCheckNamedValue) CheckNamedValue(_ *driver.NamedValue) (err error) {

magefiles/mage.go

@@ -14,3 +14,9 @@ func Lint(ctx context.Context) error {
 	args := []string{"run", "--config", ".golangci.yml"}
 	return sh.RunV("golangci-lint", args...)
 }
+
+// Test runs the tests
+func Test(ctx context.Context) error {
+	args := []string{"test", "-v", "-race", "./..."}
+	return sh.RunV("go", args...)
+}

rows_test.go

@@ -109,7 +109,7 @@ func TestRowsNext(t *testing.T) {
 	stmt := fakeStmt{
 		rows: rows,
 	}
-	con.stmt = stmt
+	con.queryStmt = stmt
 	driverName := driverName(t)
 	interceptor := rowsNextInterceptor{}
 
@@ -199,7 +199,7 @@ func TestRows_LikePGX(t *testing.T) {
 	stmt := fakeStmt{
 		rows: rows,
 	}
-	con.stmt = stmt
+	con.queryStmt = stmt
 	driverName := driverName(t)
 	interceptor := rowsNextInterceptor{}
 

tools/rows_picker_gen.go

@@ -1,4 +1,4 @@
-// +build ignore
+//go:build ignore
 
 package main