Skip to content

Commit 8818b91

Browse files
committed
Merge branch 'develop'
Merge details: commit 85259b7 Author: Jelle Sebreghts <sebreghts.jelle@gmail.com> Date: Tue Jul 2 16:29:40 2019 Refactoring to move away from monolithic RoboFile. - Use the command builder - Define task classes and traits Why we use traits instead of command classes. Command classes define a command. Each public method on a RoboFile (in the root of the project) is also a command. Public methods can be overridden by the RoboFile. Command classes cannot (at least not in a reliable way, there's no way of telling robo which of the command classes that define a command with the same name, is the actual command you want to use). I also introduced TraitDependencyCheckerTrait (not my proudest moment), because traits cannot extend other traits, but some have overlapping functionality, and, you know, DRY. This trait helps other traits define dependencies (on yet some other traits) and checks if these dependencies are met. Just add a method named get[MyTraitClassName]Dependencies, and return an array of full trait names (with namespace). If the class using this trait doesn't also use every dependend trait, an exception will be thrown. Also: Roave/BetterReflection#486
2 parents 02d05cb + 52847fa commit 8818b91

28 files changed

+2452
-1403
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ env:
44
language: php
55
php:
66
- 7.1
7-
- 7.0
7+
- 7.2
8+
- 7.3
89
before_script:
910
- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
1011
- chmod +x ./cc-test-reporter

composer.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@
66
"prefer-stable": true,
77
"require": {
88
"digipolisgent/robo-digipolis-package": "^0.1",
9-
"digipolisgent/robo-digipolis-deploy": "^0.1.4",
9+
"digipolisgent/robo-digipolis-deploy": "^0.1.9",
1010
"digipolisgent/robo-digipolis-general": "^0.1",
1111
"gordalina/cachetool": "^3|^2.1|^1.11",
12-
"digipolisgent/command-builder": "^1.0"
12+
"digipolisgent/command-builder": "^1.2.1",
13+
"roave/better-reflection": "^3.0|^2.0"
1314
},
1415
"require-dev": {
1516
"phpunit/phpunit": "~4.4"

0 commit comments

Comments
 (0)