Failed to find any playable formats by Promise.allSettled

[ductridev]

Describe the bug and how to reproduce it

I have to open another issue related to #273 since it looks like not from syntax. But it is related to how Promise.allSettled & Promise.all handle the reject.

I have many responses when using Promise.allSettled:

{
    status: 'rejected',
    reason: UnrecoverableError: Sign in to confirm you’re not a bot
        at exports.playError (/home/container/node_modules/@distube/ytdl-core/lib/utils.js:168:12)
        at playerAPI (/home/container/node_modules/@distube/ytdl-core/lib/info.js:433:25)
        at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
        at async fetchWebEmbeddedPlayer (/home/container/node_modules/@distube/ytdl-core/lib/info.js:397:10)
        at async Promise.allSettled (index 0)
        at async exports.getInfo (/home/container/node_modules/@distube/ytdl-core/lib/info.js:257:25)
  }

Then I think the problem is it should be Promise.all so will throw an error when rejected, and then will try sig.decipherFormats after catching the reject. That's my thought, maybe I'm wrong, but at least it works lol. Happy to hear your guys' opinions.

Environment

• @distube/ytdl-core version: 4.16.12
• Node.js version: v20.18.0
• Operating system: Linux

[ductridev]

This is my patch if someone want to try:

diff --git a/node_modules/@distube/ytdl-core/lib/info.js b/node_modules/@distube/ytdl-core/lib/info.js
index 88500fd..f06fe50 100644
--- a/node_modules/@distube/ytdl-core/lib/info.js
+++ b/node_modules/@distube/ytdl-core/lib/info.js
@@ -254,7 +254,7 @@ exports.getInfo = async (id, options) => {
     if (options.playerClients.includes("ANDROID")) clientPromises.push(fetchAndroidJsonPlayer(id, options));
 
     if (clientPromises.length > 0) {
-      const responses = await Promise.allSettled(clientPromises);
+      const responses = await Promise.all(clientPromises);
       const successfulResponses = responses
         .filter(r => r.status === "fulfilled")
         .map(r => r.value)
@@ -272,8 +272,6 @@ exports.getInfo = async (id, options) => {
     }
 
     if (options.playerClients.includes("WEB")) {
-      bestPlayerResponse = info.player_response;
-
       const formats = parseFormats(info.player_response);
       if (formats && formats.length > 0) {
         formatPromises.push(sig.decipherFormats(formats, info.html5player, options));