Added tests for CreditCardRule

Author: ditschedev

.travis.yml

@@ -1 +1,3 @@
-language: java
+language: java
+after_success:
+  - bash <(curl -s https://codecov.io/bash)

src/main/java/dev/ditsche/validator/rule/ruleset/CreditCardRule.java

@@ -12,7 +12,7 @@
  */
 public class CreditCardRule implements Rule {
 
-    private final String PATTERN = "^(\\\\d{4}[- ]?){3}\\\\d{4}$";
+    private final String PATTERN = "^(\\d{4}[- ]?){3}\\d{4}$";
 
     @Override
     public RuleResult passes(Object value) {
@@ -25,6 +25,6 @@ public RuleResult passes(Object value) {
 
     @Override
     public String message(String field) {
-        return String.format("The field \"%s\" needs to be a valid credit card", field);
+        return String.format("The field \"%s\" needs to be a valid credit card number", field);
     }
 }

src/test/java/dev/ditsche/validator/ValidatorTest.java

@@ -2,11 +2,11 @@
 
 import dev.ditsche.validator.dto.NestedEntity;
 import dev.ditsche.validator.dto.TestEntity;
-import dev.ditsche.validator.error.ValidationException;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import static dev.ditsche.validator.rule.builder.Rules.*;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class ValidatorTest {
 
@@ -19,8 +19,9 @@ public void setUp() {
 
     @Test
     public void shouldValidateExample() {
-        TestEntity testEntity = new TestEntity("Mr", "[email protected]", "Tobias", 4, new NestedEntity("Max"));
-
+        final String email = "[email protected]  ";
+        TestEntity testEntity = new TestEntity("Mr", email, "Tobias", 4, new NestedEntity("Max"));
+        assertThat(email).isEqualTo(testEntity.getEmail());
         validator = Validator.fromRules(
                 string("title").required().trim().max(3),
                 string("email").required().trim().email(),
@@ -30,12 +31,9 @@ public void shouldValidateExample() {
                         string("name").required().trim().min(1)
                 )
         );
+        testEntity = validator.validate(testEntity);
+        assertThat(email).isNotEqualTo(testEntity.getEmail());
 
-        try {
-            testEntity = validator.validate(testEntity);
-        } catch (ValidationException ex) {
-            throw  ex;
-        }
     }
 
 }

src/test/java/dev/ditsche/validator/rule/ruleset/CreditCardRuleTest.java

@@ -0,0 +1,40 @@
+package dev.ditsche.validator.rule.ruleset;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.LinkedList;
+import java.util.stream.Stream;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class CreditCardRuleTest {
+
+    private final CreditCardRule creditCardRule = new CreditCardRule();
+
+    @Test
+    public void shouldFailIfNoStringIsProvided() {
+        Stream.of(null, 1, new LinkedList<>(), 2.00f).forEach(value -> {
+            assertThat(creditCardRule.passes(value).isPassed()).isFalse();
+        });
+    }
+
+    @Test
+    public void shouldFailIfStringIsInvalid() {
+        Stream.of("", "2222-2222-2222-222a", "4242-2424-4242-04 3").forEach(value -> {
+            assertThat(creditCardRule.passes(value).isPassed()).isFalse();
+        });
+    }
+
+    @Test
+    public void shouldPassWithValidCreditCardNumber() {
+        Stream.of("2222-2222-2222-2222", "4242-2424-4242-4242").forEach(value -> {
+            assertThat(creditCardRule.passes(value).isPassed()).isTrue();
+        });
+    }
+
+    @Test
+    public void shouldReturnValidErrorMessage() {
+        assertThat(creditCardRule.message("test")).isEqualTo("The field \"test\" needs to be a valid credit card number");
+    }
+
+}