fix: lint formating

Author: EstherRocio012

app/modules/dataset/routes.py

@@ -3,19 +3,31 @@
 import shutil
 import tempfile
 from datetime import datetime
-from flask import abort, current_app, jsonify, make_response, redirect, render_template, request, send_file, url_for, flash
+
+from flask import (
+    abort,
+    current_app,
+    flash,
+    jsonify,
+    make_response,
+    redirect,
+    render_template,
+    request,
+    send_file,
+    url_for,
+)
 from flask_login import current_user, login_required
 
 from app.modules.apikeys.decorators import require_api_key
 from app.modules.dataset import dataset_bp
 from app.modules.dataset.decorators import is_dataset_owner
 from app.modules.dataset.forms import DataSetForm
-from app.modules.dataset.models import DataSet
+from app.modules.dataset.models import DataSet, PublicationType
 from app.modules.dataset.services import (
     AuthorService,
-    DataSetService,
     DatasetMetadataUpdateError,
     DatasetMetadataValidationError,
+    DataSetService,
     DOIMappingService,
     DSDownloadRecordService,
     DSMetaDataService,
@@ -28,7 +40,6 @@
 from app.modules.hubfile.models import Hubfile
 from app.modules.hubfile.services import HubfileService
 from app.modules.zenodo.services import ZenodoDatasetService, ZenodoService
-from app.modules.dataset.models import PublicationType
 
 logger = logging.getLogger(__name__)
 
@@ -119,15 +130,16 @@ def create_dataset():
     hubfile_service.clear_temp()
     return render_template("dataset/create_and_edit_dataset.html", form=form)
 
-@dataset_bp.route('/dataset/edit/<int:dataset_id>', methods=['GET', 'POST'])
+
+@dataset_bp.route("/dataset/edit/<int:dataset_id>", methods=["GET", "POST"])
 @login_required
 def edit_metadata(dataset_id):
     dataset = dataset_service.get_or_404(dataset_id)
     form = DataSetForm()
     if dataset.user_id != current_user.id:
         abort(403)
 
-    if request.method == 'POST':
+    if request.method == "POST":
         is_ajax = request.headers.get("X-Requested-With") == "XMLHttpRequest"
         try:
             dataset_service.update_metadata_from_request(dataset, request.form, zenodo_service=zenodo_service)
@@ -149,9 +161,16 @@ def edit_metadata(dataset_id):
                 return jsonify({"message": f"Unexpected error updating metadata: {exc}"}), 400
             flash(f"Unexpected error updating metadata: {exc}", "danger")
 
-        return redirect(url_for('dataset.list_dataset'))
+        return redirect(url_for("dataset.list_dataset"))
+
+    return render_template(
+        "dataset/create_and_edit_dataset.html",
+        dataset=dataset,
+        is_edit=True,
+        form=form,
+        PublicationType=PublicationType,
+    )
 
-    return render_template('dataset/create_and_edit_dataset.html', dataset=dataset, is_edit = True, form=form, PublicationType=PublicationType)
 
 @dataset_bp.route("/datasets/list", methods=["GET"])
 @login_required

app/modules/dataset/services.py

@@ -168,9 +168,7 @@ def _validate_orcid(self, orcid: str) -> str:
             )
             with urllib_request.urlopen(req, timeout=5) as response:
                 if response.status != 200:
-                    raise DatasetMetadataValidationError(
-                        f"Could not validate ORCID (status {response.status})."
-                    )
+                    raise DatasetMetadataValidationError(f"Could not validate ORCID (status {response.status}).")
         except urllib_error.HTTPError as exc:
             if exc.code == 404:
                 raise DatasetMetadataValidationError("ORCID not found.")
@@ -297,9 +295,7 @@ def _sync_metadata_in_zenodo_if_needed(self, dataset: DataSet, zenodo_service) -
         if not deposition_id:
             raise DatasetMetadataUpdateError("Dataset is synchronized but missing Zenodo deposition_id.")
 
-        metadata = zenodo_service.build_metadata(
-            dataset, anonymous=dataset.ds_meta_data.dataset_anonymous
-        )
+        metadata = zenodo_service.build_metadata(dataset, anonymous=dataset.ds_meta_data.dataset_anonymous)
         zenodo_service.update_deposition(deposition_id, metadata)
 
     def _publish_dataset_to_zenodo(self, dataset: DataSet, zenodo_service) -> None:

app/modules/dataset/tests/test_unit.py

@@ -1,14 +1,14 @@
-from urllib.error import HTTPError
 from unittest.mock import MagicMock, patch
+from urllib.error import HTTPError
 
 import pytest
 from werkzeug.datastructures import MultiDict
 
 from app import create_app
 from app.modules.dataset.services import (
-    DataSetService,
     DatasetMetadataUpdateError,
     DatasetMetadataValidationError,
+    DataSetService,
 )
 
 
@@ -111,9 +111,11 @@ def test_update_metadata_from_request_success():
         ]
     )
 
-    with patch.object(service, "zip_dataset", return_value="C:\\tmp\\dataset_1.zip"), patch(
-        "app.modules.dataset.services.os.path.exists", return_value=True
-    ), patch("app.modules.dataset.services.shutil.rmtree"):
+    with (
+        patch.object(service, "zip_dataset", return_value="C:\\tmp\\dataset_1.zip"),
+        patch("app.modules.dataset.services.os.path.exists", return_value=True),
+        patch("app.modules.dataset.services.shutil.rmtree"),
+    ):
         service.update_metadata_from_request(dataset, form_data, zenodo_service=zenodo_service)
 
     assert dataset.ds_meta_data.title == "Updated dataset"
@@ -371,9 +373,11 @@ def test_update_metadata_from_request_unsynced_dataset_to_zenodo_publishes_and_s
     zenodo_service.publish_deposition = MagicMock()
     zenodo_service.get_doi.return_value = "10.5072/zenodo.101"
 
-    with patch.object(service, "zip_dataset", return_value="C:\\tmp\\dataset_1.zip"), patch(
-        "app.modules.dataset.services.os.path.exists", return_value=True
-    ), patch("app.modules.dataset.services.shutil.rmtree"):
+    with (
+        patch.object(service, "zip_dataset", return_value="C:\\tmp\\dataset_1.zip"),
+        patch("app.modules.dataset.services.os.path.exists", return_value=True),
+        patch("app.modules.dataset.services.shutil.rmtree"),
+    ):
         form_data = MultiDict(
             [("title", "Updated dataset"), ("description", "Updated description"), ("dataset_type", "zenodo")]
         )