Skip to content

Commit 8300e88

Browse files
fix: coderrabit suggestions
1 parent 7ec165c commit 8300e88

File tree

4 files changed

+72
-58
lines changed

4 files changed

+72
-58
lines changed

app/sagas/login.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,14 @@ const fetchWatchReplies = function* fetchWatchRepliesFork() {
228228
try {
229229
// we are getting replies from server settings
230230
const state = yield select(state => state);
231+
232+
if (!state.settings?.Apple_Watch_Quick_Actions) {
233+
yield delay(1000);
234+
const newState = yield select();
235+
syncWatchOSQuickRepliesWithServer(newState);
236+
return;
237+
}
238+
231239
syncWatchOSQuickRepliesWithServer(state);
232240
} catch (e) {
233241
log(e);

ios/RCTWatchModule.mm

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,7 @@ - (NSString *)syncQuickReplies {
124124
return message;
125125
}
126126

127-
NSString *replies = [array componentsJoinedByString:@", "];
128-
return replies;
127+
return @"SUCCESS";
129128
} catch (const std::exception &e) {
130129
NSString *message = @"[ERROR]: Watch sync exception";
131130
RCTLogError(@"Watch sync exception: %s", e.what());

ios/RocketChat Watch App/Views/MessageComposerView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ struct MessageComposerView: View {
44
@State private var message = ""
55

66
let room: Room
7-
let server: Server
7+
@ObservedObject var server: Server
88
let anchorID: String
99
let onSend: (String) -> Void
1010

ios/RocketChat Watch App/Views/MessageListView.swift

Lines changed: 62 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -44,64 +44,70 @@ struct MessageListView: View {
4444
}
4545
Spacer()
4646
}
47-
}
48-
ScrollViewReader{ proxy in
49-
50-
ChatScrollView {
51-
VStack(spacing: 0) {
52-
if room.hasMoreMessages {
53-
Button("Load more...") {
54-
guard let oldestMessage = room.firstMessage?.ts
55-
else { return }
56-
57-
messagesLoader.loadMore(from: oldestMessage)
47+
} else {
48+
ScrollViewReader { proxy in
49+
ChatScrollView {
50+
VStack(spacing: 0) {
51+
if room.hasMoreMessages {
52+
Button("Load more...") {
53+
guard
54+
let oldestMessage = room.firstMessage?
55+
.ts
56+
else { return }
57+
58+
messagesLoader.loadMore(from: oldestMessage)
59+
}
60+
.padding(.bottom, 8)
5861
}
59-
.padding(.bottom, 8)
60-
}
61-
62-
ForEach(messages.indices, id: \.self) { index in
63-
let message = messages[index]
64-
let previousMessage =
65-
messages.indices.contains(index - 1)
66-
? messages[index - 1] : nil
67-
68-
MessageView(
69-
viewModel: .init(
70-
message: message,
71-
previousMessage: previousMessage,
72-
server: server,
73-
lastOpen: lastOpen
74-
)
75-
) { action in
76-
switch action {
77-
case .resend(let message):
78-
messageSender.resendMessage(
62+
63+
ForEach(messages.indices, id: \.self) { index in
64+
let message = messages[index]
65+
let previousMessage =
66+
messages.indices.contains(index - 1)
67+
? messages[index - 1] : nil
68+
69+
MessageView(
70+
viewModel: .init(
7971
message: message,
80-
in: room
72+
previousMessage: previousMessage,
73+
server: server,
74+
lastOpen: lastOpen
8175
)
82-
83-
lastOpen = nil
84-
case .delete(let message):
85-
database.remove(message)
76+
) { action in
77+
switch action {
78+
case .resend(let message):
79+
messageSender.resendMessage(
80+
message: message,
81+
in: room
82+
)
83+
84+
lastOpen = nil
85+
case .delete(let message):
86+
database.remove(message)
87+
}
8688
}
8789
}
90+
91+
MessageComposerView(
92+
room: room,
93+
server: server,
94+
anchorID: bottomAnchor
95+
) {
96+
messageSender.sendMessage($0, in: room)
97+
98+
lastOpen = nil
99+
}
100+
.id(messageComposer)
101+
.padding(.top, 8)
88102
}
89-
90-
MessageComposerView(room: room, server: server, anchorID: bottomAnchor) {
91-
messageSender.sendMessage($0, in: room)
92-
93-
lastOpen = nil
103+
.onAppear {
104+
scrollToBottom(proxy: proxy)
94105
}
95-
.id(messageComposer)
96-
.padding(.top, 8)
97-
}
98-
.onAppear {
99-
scrollToBottom(proxy: proxy)
100-
}
101-
.onChange(of: messages.last?.ts) { _ in
102-
// Also scroll to bottom when new messages arrive
103-
withAnimation(.easeOut(duration: 0.3)) {
104-
proxy.scrollTo(bottomAnchor, anchor: .center)
106+
.onChange(of: messages.last?.ts) { _ in
107+
// Also scroll to bottom when new messages arrive
108+
withAnimation(.easeOut(duration: 0.3)) {
109+
proxy.scrollTo(bottomAnchor, anchor: .center)
110+
}
105111
}
106112
}
107113
}
@@ -144,10 +150,11 @@ struct MessageListView: View {
144150
}
145151
}
146152
}
153+
147154
private func scrollToBottom(proxy: ScrollViewProxy) {
148-
// Small delay ensures layout is complete before scrolling
149-
DispatchQueue.main.asyncAfter(deadline: .now() + 0.05) {
150-
proxy.scrollTo(bottomAnchor, anchor: .bottom)
151-
}
155+
// Small delay ensures layout is complete before scrolling
156+
DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
157+
proxy.scrollTo(bottomAnchor, anchor: .bottom)
152158
}
159+
}
153160
}

0 commit comments

Comments
 (0)