Skip to content

Commit 59a0437

Browse files
committed
Update tests
1 parent a21aca1 commit 59a0437

File tree

4 files changed

+24
-7
lines changed

4 files changed

+24
-7
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ jobs:
1313
django-4.2.txt,
1414
django-5.0.txt,
1515
django-5.1.txt,
16+
django-5.2.txt,
1617
django-main.txt,
1718
]
1819
custom-image-model: [false, true]
@@ -24,12 +25,14 @@ jobs:
2425
python-version: 3.9
2526
- requirements-file: django-5.1.txt
2627
python-version: 3.9
28+
- requirements-file: django-5.2.txt
29+
python-version: 3.9
30+
- requirements-file: django-main.txt
31+
python-version: 3.9
2732
- requirements-file: django-main.txt
2833
python-version: 3.10
2934
- requirements-file: django-main.txt
3035
python-version: 3.11
31-
- requirements-file: django-main.txt
32-
python-version: 3.9
3336

3437
steps:
3538
- uses: actions/checkout@v1

filer/admin/folderadmin.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from urllib.parse import quote as urlquote
66
from urllib.parse import unquote as urlunquote
77

8+
from django import VERSION as DJANGO_VERSION
89
from django import forms
910
from django.conf import settings as django_settings
1011
from django.contrib import messages
@@ -777,9 +778,14 @@ def delete_files_or_folders(self, request, files_queryset, folders_queryset):
777778
n = files_queryset.count() + folders_queryset.count()
778779
if n:
779780
# delete all explicitly selected files
780-
for f in files_queryset:
781-
self.log_deletion(request, f, force_str(f))
782-
f.delete()
781+
if DJANGO_VERSION >= (5,1):
782+
self.log_deletions(request, files_queryset)
783+
for f in files_queryset:
784+
f.delete()
785+
else:
786+
for f in files_queryset:
787+
self.log_deletion(request, f, force_str(f))
788+
f.delete()
783789
# delete all files in all selected folders and their children
784790
# This would happen automatically by ways of the delete
785791
# cascade, but then the individual .delete() methods won't be

tests/requirements/django-5.2.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
-r base.txt
2+
3+
django>=5.2a1,<5.3
4+
django_polymorphic>=3.1

tox.ini

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@ envlist =
44
isort
55
docs
66
frontend
7-
py{310,311,312}-{dj42,dj50,djmain}-{swap,noswap}
7+
py{310,311,312}-{dj42,dj50,dj51,dj52}-{swap,noswap}
8+
py{312,313,312}-{djmain}-{swap,noswap}
89

910
[gh-actions]
1011
python =
1112
3.10: py310
1213
3.11: py311
1314
3.12: py312
15+
3.13: py313
1416

1517
skip_missing_interpreters=True
1618

@@ -21,11 +23,13 @@ allowlist_externals =
2123
deps =
2224
dj42: -r tests/requirements/django-4.2.txt
2325
dj50: -r tests/requirements/django-5.0.txt
26+
dj51: -r tests/requirements/django-5.1.txt
27+
dj52: -r tests/requirements/django-5.2.txt
2428
djmain: -r tests/requirements/django-main.txt
2529
commands =
2630
{envpython} --version
2731
{env:COMMAND:coverage} erase
28-
{env:COMMAND:coverage} run setup.py test
32+
{env:COMMAND:coverage} run tests/settings.py
2933
{env:COMMAND:coverage} report
3034
setenv =
3135
swap: CUSTOM_IMAGE=custom_image.Image

0 commit comments

Comments
 (0)