Skip to content

Commit 8293ba1

Browse files
authored
fix: JavaScript int literal overflow (#1422)
* Update directory_table_list.html * Update CHANGELOG.rst * Update directory_thumbnail_list.html
1 parent 72e2d41 commit 8293ba1

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ CHANGELOG
55
unreleased
66
==========
77

8+
* Fixed two more instances of javascript int overflow issue (#1335)
89
* fix: ensure uniqueness of icon admin url names
910

1011
3.0.6 (2023-09-08)

filer/templates/admin/filer/folder/directory_table_list.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
</td>
101101
<td class="column-icon">
102102
{% if is_popup and filer_admin_context.pick_file %}
103-
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, {{ file.id|unlocalize }}, '{% file_icon_url file %}', '{{ file.label|escapejs }}', '{{ file.get_admin_change_url }}'); return false;"
103+
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, '{{ file.id|unlocalize }}', '{% file_icon_url file %}', '{{ file.label|escapejs }}', '{{ file.get_admin_change_url }}'); return false;"
104104
title="{% translate 'Select this file' %}">
105105
{% elif has_change_permission %}
106106
<a href="{{ file.get_admin_change_url }}{% filer_admin_context_url_params %}"
@@ -115,7 +115,7 @@
115115
<div>
116116
<strong>
117117
{% if is_popup and filer_admin_context.pick_file %}
118-
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, {{ file.id|unlocalize }}, '{% file_icon_url file %}', '{{ file.label|escapejs }}', '{{ file.get_admin_change_url }}'); return false;"
118+
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, '{{ file.id|unlocalize }}', '{% file_icon_url file %}', '{{ file.label|escapejs }}', '{{ file.get_admin_change_url }}'); return false;"
119119
title="{% translate 'Select this file' %}">
120120
{% elif has_change_permission %}
121121
<a href="{{ file.get_admin_change_url }}{% filer_admin_context_url_params %}"

filer/templates/admin/filer/folder/directory_thumbnail_list.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
<div class="thumbnail-file-item-box">
101101
<div class="item-thumbnail">
102102
{% if is_popup and filer_admin_context.pick_file %}
103-
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, {{ file.id|unlocalize }}, '{% file_icon_url file %}', '{{ file.label|escapejs }}'); return false;"
103+
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, '{{ file.id|unlocalize }}', '{% file_icon_url file %}', '{{ file.label|escapejs }}'); return false;"
104104
title="{% translate 'Select this file' %}">
105105
{% elif has_change_permission %}
106106
<a href="{{ file.get_admin_change_url }}{% filer_admin_context_url_params %}"
@@ -115,7 +115,7 @@
115115
<div class="item-name">
116116
<div>
117117
{% if is_popup and filer_admin_context.pick_file %}
118-
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, {{ file.id|unlocalize }}, '{% file_icon_url file %}', '{{ file.label|escapejs }}'); return false;"
118+
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, '{{ file.id|unlocalize }}', '{% file_icon_url file %}', '{{ file.label|escapejs }}'); return false;"
119119
title="{% translate 'Select this file' %}">
120120
{% elif has_change_permission %}
121121
<a href="{{ file.get_admin_change_url }}{% filer_admin_context_url_params %}"

0 commit comments

Comments
 (0)