fix: set default values for max filename length and random suffix in _ensure_safe_length

Author: Baraff24

filer/utils/files.py

@@ -123,7 +123,7 @@ def slugify(string):
     return slugify_django(force_str(string))
 
 
-def _ensure_safe_length(filename, max_length=None, random_suffix_length=None):
+def _ensure_safe_length(filename, max_length=155, random_suffix_length=16):
     """
     Ensures that the filename does not exceed the maximum allowed length.
     If it does, the function truncates the filename and appends a random hexadecimal
@@ -142,9 +142,6 @@ def _ensure_safe_length(filename, max_length=None, random_suffix_length=None):
     Reference issue: https://github.com/django-cms/django-filer/issues/1270
     """
 
-    max_length = max_length or getattr(settings, "FILER_MAX_FILENAME_LENGTH", 255)
-    random_suffix_length = random_suffix_length or getattr(settings, "FILER_RANDOM_SUFFIX_LENGTH", 16)
-
     if len(filename) <= max_length:
         return filename
 

tests/test_files.py

@@ -11,8 +11,8 @@ def setUp(self):
         """
         Set up the test case by reading the configuration settings for the maximum filename length.
         """
-        self.max_length = getattr(settings, "FILER_MAX_FILENAME_LENGTH", 255)
-        self.random_suffix_length = getattr(settings, "FILER_RANDOM_SUFFIX_LENGTH", 16)
+        self.max_length = 155
+        self.random_suffix_length = 16
 
     def test_short_filename_remains_unchanged(self):
         """
@@ -69,7 +69,7 @@ def test_edge_case_exact_length(self):
         Test that a filename exactly at the maximum allowed length remains unchanged.
         """
         extension = ".png"
-        base_length = 255 - len(extension)
+        base_length = 155 - len(extension)
         base = "b" * base_length
         original = f"{base}{extension}"
         result = get_valid_filename(original)