Skip to content

Commit 205f8cc

Browse files
authored
Merge pull request #374 from divio/bugfix/tabular-inline
Fixed string representation in the tabular inline
2 parents 6f97581 + aa31999 commit 205f8cc

File tree

9 files changed

+71
-10
lines changed

9 files changed

+71
-10
lines changed

CHANGELOG.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
CHANGELOG
22
=========
33

4+
1.2.5 (unreleased)
5+
------------------
6+
7+
* Fixed string representation in the tabular inline
8+
9+
410
1.2.4 (2016-09-15)
511
------------------
612

djangocms_admin_style/sass/components/_content.scss

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ ul.messagelist + #content {
158158
border-radius: 0;
159159
background: none !important;
160160
box-shadow: none;
161+
overflow: auto;
161162
h2 {
162163
font-size: $font-size-large !important;
163164
margin-bottom: 10px;
@@ -185,10 +186,6 @@ ul.messagelist + #content {
185186
border-bottom: none !important;
186187
}
187188
}
188-
.module {
189-
overflow: auto;
190-
width: 80%;
191-
}
192189
.add-row {
193190
border-bottom: 0 !important;
194191
&,

djangocms_admin_style/sass/components/_tables.scss

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
border-right: 0 !important;
3030
}
3131
p,
32-
a {
32+
a:not(.cke_button) {
3333
font-size: $font-size-normal !important;
3434
line-height: $font-size-normal;
3535
font-weight: normal;
@@ -324,24 +324,27 @@
324324
}
325325
}
326326
tbody td {
327+
padding-top: 46px !important;
327328
input[type="checkbox"] {
328329
line-height: 36px;
329330
height: 36px;
330331
}
332+
> p {
333+
line-height: 36px;
334+
}
331335
a:not(.related-widget-wrapper-link):not(.add-another):before {
332336
vertical-align: middle;
333337
line-height: 36px;
334338
}
335339
}
336340
td.original {
337-
// make sure that there is no padding if there is no content #252
338-
padding: 0 !important;
341+
padding-left: 0 !important;
342+
padding-right: 0 !important;
339343
p {
340-
position: static !important;
341344
line-height: 36px !important;
342345
height: 36px !important;
343346
font-weight: normal !important;
344-
padding: 0 !important;
347+
padding: 0 13px !important;
345348
}
346349
.vForeignKeyRawIdAdminField {
347350
width: auto;

djangocms_admin_style/static/djangocms_admin_style/css/djangocms-admin.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

djangocms_admin_style/tests/integration/adminsortable2.js

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,61 @@ casper.test.begin('Creation of a new job opening', function (test) {
211211
});
212212
});
213213

214+
casper.test.begin('Submission of a job opening', function (test) {
215+
casper.start()
216+
.then(cms.addPage({ title: 'Home' }))
217+
.then(cms.addPage({ title: 'Jobs' }))
218+
.then(cms.addApphookToPage({
219+
page: 'Jobs',
220+
apphook: 'JobsApp'
221+
}))
222+
.then(cms.publishPage({
223+
page: 'Jobs'
224+
}))
225+
.thenOpen(globals.baseUrl + 'jobs/')
226+
.waitForSelector('article', function () {
227+
this.clickLabel('Test job');
228+
})
229+
.waitForSelector('form', function () {
230+
this.fill('form', {
231+
salutation: 'male',
232+
first_name: 'Vadim',
233+
last_name: 'Sikora',
234+
235+
cover_letter: 'Oh boy, I am amazing!'
236+
}, true);
237+
})
238+
.waitForSelector('.cms-messages-inner', function () {
239+
test.assertSelectorHasText('.cms-messages-inner', 'You have successfully applied for');
240+
})
241+
.thenOpen(globals.adminUrl)
242+
.waitUntilVisible('#content', function () {
243+
this.click(
244+
xPath(cms.getXPathForAdminSection({
245+
section: 'Aldryn Jobs',
246+
row: 'Job openings',
247+
link: 'Change'
248+
}))
249+
);
250+
})
251+
.waitForUrl(/jobopening/)
252+
.waitForSelector('#changelist-form', function () {
253+
this.clickLabel('Test job');
254+
})
255+
.waitUntilVisible('#jobopening_form')
256+
.wait(2000, function () {
257+
phantomcss.screenshot('html', 'Job opening with submissions');
258+
})
259+
.then(function () {
260+
phantomcss.compareSession();
261+
})
262+
.then(cms.removePage())
263+
.then(cms.removePage())
264+
.run(function () {
265+
test.done();
266+
});
267+
});
268+
214269
casper.test.begin('Deletion of a job opening', function (test) {
215270
casper
216271
.start(globals.adminUrl)
-802 Bytes
Loading
-9.89 KB
Loading
61 Bytes
Loading
111 KB
Loading

0 commit comments

Comments
 (0)