fix: Only allow turning plugins into alias if they can be a root plugin (#286)

fsbraun · sourcery-ai[bot] · web-flow · commit 276201224a95 · 2025-08-29T13:17:52.000+05:30
* fix: Only allow turning plugins into alias if they can be a root plugin

* Update djangocms_alias/static/djangocms_alias/js/databridge.js

Co-authored-by: sourcery-ai[bot] &lt;58596630+sourcery-ai[bot]@users.noreply.github.com&gt;

* fix tests

* fix: Improve databridge.js

* fix: non-breaking space replaced

* feat: Allow for fast v5 screen update

* fix: Some more fixes, including standard form rendering

---------

Co-authored-by: sourcery-ai[bot] &lt;58596630+sourcery-ai[bot]@users.noreply.github.com&gt;
diff --git a/djangocms_alias/cms_plugins.py b/djangocms_alias/cms_plugins.py
@@ -1,7 +1,7 @@
 from cms.models import Page
 from cms.plugin_base import CMSPluginBase, PluginMenuItem
 from cms.plugin_pool import plugin_pool
-from cms.toolbar.utils import get_object_edit_url
+from cms.toolbar.utils import get_object_edit_url, get_plugin_toolbar_info, get_plugin_tree
 from cms.utils import get_language_from_request
 from cms.utils.permissions import (
     get_model_permission_codename,
@@ -38,11 +38,36 @@ class Alias(CMSPluginBase):
     model = AliasPlugin
     form = AliasPluginForm
 
+    create_alias_fieldset = (
+        (
+            None,
+            {
+                "fields": (
+                    "name",
+                    "site",
+                    "category",
+                    "replace",
+                    "plugin",
+                    "placeholder",
+                    "language",
+                ),
+            },
+        ),
+    )
+
+    autocomplete_fields = ["alias"]
+
     def get_render_template(self, context, instance, placeholder):
         if isinstance(instance.placeholder.source, AliasContent) and instance.is_recursive():
             return "djangocms_alias/alias_recursive.html"
         return f"djangocms_alias/{instance.template}/alias.html"
 
+    @classmethod
+    def _get_allowed_root_plugins(cls):
+        if not hasattr(cls, "_cached_allowed_root_plugins"):
+            cls._cached_allowed_root_plugins = set(plugin_pool.get_all_plugins(root_plugin=True))
+        return cls._cached_allowed_root_plugins
+
     @classmethod
     def get_extra_plugin_menu_items(cls, request, plugin):
         if plugin.plugin_type == cls.__name__:
@@ -82,15 +107,19 @@ def get_extra_plugin_menu_items(cls, request, plugin):
             "plugin": plugin.pk,
             "language": get_language_from_request(request),
         }
-        endpoint = add_url_parameters(admin_reverse(CREATE_ALIAS_URL_NAME), **data)
-        return [
-            PluginMenuItem(
-                _("Create Alias"),
-                endpoint,
-                action="modal",
-                attributes={"cms-icon": "alias"},
-            ),
-        ]
+        # Check if the plugin can become root: Should be allowed as a root plugin (in the alias)
+        can_become_alias = plugin.get_plugin_class() in cls._get_allowed_root_plugins()
+        if can_become_alias:
+            endpoint = add_url_parameters(admin_reverse(CREATE_ALIAS_URL_NAME), **data)
+            return [
+                PluginMenuItem(
+                    _("Create Alias"),
+                    endpoint,
+                    action="modal",
+                    attributes={"cms-icon": "alias"},
+                ),
+            ]
+        return []
 
     @classmethod
     def get_extra_placeholder_menu_items(cls, request, placeholder):
@@ -150,6 +179,7 @@ def detach_alias_plugin(cls, plugin, language):
         source_plugins = plugin.alias.get_plugins(language, show_draft_content=True)  # We're in edit mode
         target_placeholder = plugin.placeholder
         plugin_position = plugin.position
+        plugin_parent = plugin.parent
         target_placeholder.delete_plugin(plugin)
         if source_plugins:
             if target_last_plugin := target_placeholder.get_last_plugin(plugin.language):
@@ -163,6 +193,7 @@ def detach_alias_plugin(cls, plugin, language):
                 source_plugins,
                 placeholder=target_placeholder,
                 language=language,
+                root_plugin=plugin_parent,
                 start_positions={language: plugin_position},
             )
         return []
@@ -215,17 +246,28 @@ def create_alias_view(self, request):
         )
 
         if not create_form.is_valid():
-            opts = self.model._meta
+            from django.contrib import admin
+
+            fieldsets = self.create_alias_fieldset
+            admin_form = admin.helpers.AdminForm(create_form, fieldsets, {})
+            self.opts = self.model._meta
+            self.admin_site = admin.site
             context = {
-                "form": create_form,
-                "has_change_permission": True,
-                "opts": opts,
-                "root_path": admin_reverse("index"),
+                "title": _("Create Alias"),
+                "adminform": admin_form,
                 "is_popup": True,
-                "app_label": opts.app_label,
-                "media": (Alias().media + create_form.media),
+                "media": admin_form.media,
+                "errors": create_form.errors,
+                "preserved_filters": self.get_preserved_filters(request),
+                "inline_admin_formsets": [],
             }
-            return TemplateResponse(request, "djangocms_alias/create_alias.html", context)
+            return self.render_change_form(
+                request,
+                context,
+                add=True,
+                change=False,
+                obj=None,
+            )
 
         plugins = create_form.get_plugins()
 
@@ -242,10 +284,13 @@ def create_alias_view(self, request):
         emit_content_change([alias_content])
 
         if replace:
-            return self.render_close_frame(
+            plugin = create_form.cleaned_data.get("plugin")
+            placeholder = create_form.cleaned_data.get("placeholder")
+            return self.render_replace_response(
                 request,
-                obj=alias_plugin,
-                action="reload",
+                new_plugins=[alias_plugin],
+                source_placeholder=placeholder,
+                source_plugin=plugin,
             )
         return TemplateResponse(request, "admin/cms/page/close_frame.html")
 
@@ -258,6 +303,7 @@ def detach_alias_plugin_view(self, request, plugin_pk):
         if request.method == "GET":
             opts = self.model._meta
             context = {
+                "title": _("Detach Alias"),
                 "has_change_permission": True,
                 "opts": opts,
                 "root_path": admin_reverse("index"),
@@ -276,17 +322,48 @@ def detach_alias_plugin_view(self, request, plugin_pk):
         if not can_detach:
             raise PermissionDenied
 
-        self.detach_alias_plugin(
+        copied_plugins = self.detach_alias_plugin(
             plugin=instance,
             language=language,
         )
 
-        return self.render_close_frame(
+        return self.render_replace_response(
             request,
-            obj=instance,
-            action="reload",
+            new_plugins=copied_plugins,
+            source_plugin=instance,
         )
 
+    def render_replace_response(self, request, new_plugins, source_placeholder=None, source_plugin=None):
+        move_plugins, add_plugins = [], []
+        for plugin in new_plugins:
+            root = plugin.parent.get_bound_plugin() if plugin.parent else plugin
+
+            plugins = [root] + list(root.get_descendants())
+
+            plugin_order = plugin.placeholder.get_plugin_tree_order(
+                plugin.language,
+                parent_id=plugin.parent_id,
+            )
+            plugin_tree = get_plugin_tree(request, plugins, target_plugin=root)
+            move_data = get_plugin_toolbar_info(plugin)
+            move_data["plugin_order"] = plugin_order
+            move_data.update(plugin_tree)
+            move_plugins.append(move_data)
+            add_plugins.append({**get_plugin_toolbar_info(plugin), "structure": plugin_tree})
+        data = {
+            "addedPlugins": add_plugins,
+            "movedPlugins": move_plugins,
+            "is_popup": True,
+        }
+        if source_plugin and source_plugin.pk:
+            data["replacedPlugin"] = get_plugin_toolbar_info(source_plugin)
+        if source_placeholder and source_placeholder.pk:
+            data["replacedPlaceholder"] = {
+                "placeholder_id": source_placeholder.pk,
+                "deleted": True,
+            }
+        return self.render_close_frame(request, obj=None, action="ALIAS_REPLACE", extra_data=data)
+
     def alias_usage_view(self, request, pk):
         if not request.user.is_staff:
             raise PermissionDenied
diff --git a/djangocms_alias/forms.py b/djangocms_alias/forms.py
@@ -9,6 +9,7 @@
 from django.contrib import admin
 from django.contrib.admin.widgets import (
     AdminTextInputWidget,
+    AutocompleteSelect,
     RelatedFieldWidgetWrapper,
 )
 from django.contrib.sites.models import Site
@@ -68,6 +69,9 @@ class BaseCreateAliasForm(forms.Form):
     )
     language = forms.CharField(widget=forms.HiddenInput())
 
+    class Media:
+        js = ("djangocms_alias/js/databridge.js",)
+
     def clean(self):
         cleaned_data = super().clean()
 
@@ -104,14 +108,37 @@ class CreateAliasForm(BaseCreateAliasForm):
         required=False,
     )
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args, initial=None, **kwargs):
         self.user = kwargs.pop("user")
 
-        super().__init__(*args, **kwargs)
+        super().__init__(*args, initial=initial, **kwargs)
 
+        self.fields["site"].widget = AutocompleteSelect(
+            Alias.site.field,
+            admin.site,
+            choices=self.fields["site"].choices,
+            attrs={"data-placeholder": _("Select a site")},
+        )
+        self.fields["category"].widget = AutocompleteSelect(
+            Alias.category.field,
+            admin.site,
+            choices=self.fields["category"].choices,
+            attrs={"data-placeholder": _("Select a category")},
+        )
+
+        # Remove the replace option, if user does not have permission to add "Alias"
         if not has_plugin_permission(self.user, "Alias", "add"):
             self.fields["replace"].widget = forms.HiddenInput()
 
+        # Remove the replace option, if "Alias" cannot be a child of parent plugin
+        initial = initial or {}
+        plugin = initial.get("plugin")
+        if plugin and plugin.parent:
+            plugin_class = plugin.parent.get_plugin_class()
+            allowed_children = plugin_class.get_child_classes(plugin.placeholder.slot, instance=plugin.parent)
+            if allowed_children and "Alias" not in allowed_children:
+                self.fields["replace"].widget = forms.HiddenInput()
+
         self.set_category_widget(self.user)
         self.fields["site"].initial = get_current_site()
 
@@ -217,7 +244,7 @@ class Meta:
 class Select2Mixin:
     class Media:
         css = {
-            "all": ("cms/js/select2/select2.css",),
+            "screen": ("cms/js/select2/select2.css",),
         }
         js = (
             "admin/js/jquery.init.js",
diff --git a/djangocms_alias/models.py b/djangocms_alias/models.py
@@ -57,6 +57,7 @@ class Category(TranslatableModel):
     class Meta:
         verbose_name = _("category")
         verbose_name_plural = _("categories")
+        ordering = ["translations__name"]
 
     def __str__(self):
         # Be sure to be able to see the category name even if it's not in the current language
diff --git a/djangocms_alias/static/djangocms_alias/js/databridge.js b/djangocms_alias/static/djangocms_alias/js/databridge.js
@@ -0,0 +1,62 @@
+(function () {
+
+    const processDataBridge = function (data) {
+        let actionsPerformed = 0;
+        let updateNeeded = false;
+
+        if (data.replacedPlaceholder) {
+            updateNeeded |= CMS.API.StructureBoard.handleClearPlaceholder(data.replacedPlaceholder);
+            actionsPerformed++;
+        }
+        if (data.replacedPlugin) {
+            updateNeeded |= CMS.API.StructureBoard.handleDeletePlugin(data.replacedPlugin);
+            actionsPerformed++;
+        }
+        if (data.addedPlugins) {
+            for (const addedPlugin of data.addedPlugins) {
+                updateNeeded |= CMS.API.StructureBoard.handleAddPlugin(addedPlugin);
+                actionsPerformed++;
+            }
+        }
+        if (data.movedPlugins) {
+            for (const movedPlugin of data.movedPlugins) {
+                updateNeeded |= CMS.API.StructureBoard.handleMovePlugin(movedPlugin);
+                actionsPerformed++;
+            }
+        }
+
+        if (updateNeeded) {
+            CMS.API.StructureBoard._requestcontent = null;
+            CMS.API.StructureBoard.updateContent();
+        }
+        return actionsPerformed;
+    }
+
+    const iframe = window.parent.document.querySelector('.cms-modal-frame > iframe');
+    const {CMS} = window.parent;
+
+    if (!iframe || !CMS) {
+        return;
+    }
+
+    // Register the event handler in the capture phase to increase the chance it runs first
+    iframe.addEventListener('load', function (event) {
+        const iframeDocument = iframe.contentDocument || iframe.contentWindow.document;
+        const dataBridge = iframeDocument.body.querySelector('script#data-bridge');
+        if (dataBridge) {
+            try {
+                const data = JSON.parse(dataBridge.textContent);
+                if (data.action === 'ALIAS_REPLACE') {
+                    event.stopPropagation();
+                    dataBridge.parentNode.removeChild(dataBridge);
+                    if (processDataBridge(data)) {
+                    }
+                    iframe.dispatchEvent(new Event('load')); // re-dispatch load event to trigger modal close
+                }
+            } catch (error) {
+                window.parent.console.error('Error parsing data bridge script:', error);
+            }
+            iframeDocument.body.textContent = JSON.stringify(dataBridge);
+        }
+    }, true); // 'true' sets the event to be handled in the capture phase before the modals handler
+})();
diff --git a/djangocms_alias/templates/djangocms_alias/create_alias.html b/djangocms_alias/templates/djangocms_alias/create_alias.html
diff --git a/djangocms_alias/templates/djangocms_alias/detach_alias.html b/djangocms_alias/templates/djangocms_alias/detach_alias.html
@@ -1,6 +1,5 @@
 {% extends "admin/delete_confirmation.html" %}
-{% load i18n admin_urls cms_tags %}
-
+{% load i18n admin_urls cms_tags static %}
 {% block breadcrumbs %}{% endblock %}
 
 {% block content %}
@@ -14,7 +13,8 @@
   <input type="hidden" name="post" value="yes" />
   <div class="submit-row">
     <a href="#" class="button cancel-link">{% trans "No, take me back" %}</a>
-    <input type="submit" class="deletelink" value="{% trans "Yes, I'm sure" %}" />
+    <input type="submit" class="deletelink" value="{% translate "Yes, I'm sure" %}" />
   </div>
 </form>
+<script src="{% static 'djangocms_alias/js/databridge.js' %}"></script>
 {% endblock %}
diff --git a/tests/test_views.py b/tests/test_views.py
