Skip to content

Commit 33c5aa5

Browse files
committed
fix: Improve databridge interface
1 parent 3450458 commit 33c5aa5

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

djangocms_alias/views.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,8 @@ def create_alias_view(request):
136136
"Plugins are required to create an alias",
137137
)
138138

139+
plugin = create_form.cleaned_data.get("plugin")
140+
plugin_pk = plugin.pk if plugin else None
139141
replace = create_form.cleaned_data.get("replace")
140142
if not Alias.can_create_alias(user, plugins, replace):
141143
raise PermissionDenied
@@ -144,8 +146,9 @@ def create_alias_view(request):
144146
emit_content_change([alias_content])
145147

146148
if replace:
147-
plugin = create_form.cleaned_data.get("plugin")
148149
placeholder = create_form.cleaned_data.get("placeholder")
150+
if plugin is not None:
151+
plugin.pk = plugin_pk # Restore pk after it was set to None in form.save()
149152
return render_replace_response(
150153
request,
151154
new_plugins=[alias_plugin],
@@ -183,7 +186,7 @@ def render_replace_response(request, new_plugins, source_placeholder=None, sourc
183186
"moved_plugins": move_plugins,
184187
"is_popup": True,
185188
}
186-
if source_plugin is not None and source_plugin.pk:
189+
if source_plugin is not None:
187190
context["replaced_plugin"] = json.dumps(
188191
get_plugin_toolbar_info(source_plugin),
189192
)

0 commit comments

Comments
 (0)