Skip to content

Commit 4060eb9

Browse files
fsbraunmarksweb
andauthored
fix: Modify language menu for pages only if it is present (#179)
* fix: toolbar fails if language menu is not present * update test environment * Add test * Update compile.py * Update tests/test_toolbar.py Co-authored-by: Mark Walker <[email protected]> --------- Co-authored-by: Mark Walker <[email protected]>
1 parent e7f8256 commit 4060eb9

31 files changed

+682
-3728
lines changed

djangocms_alias/cms_toolbars.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,8 @@ def enable_create_wizard_button(self):
178178

179179
def override_language_switcher(self):
180180
language_menu = self.toolbar.get_menu(LANGUAGE_MENU_IDENTIFIER, _('Language'))
181+
if not language_menu:
182+
return
181183
# Remove all existing language links
182184
# remove_item uses `items` attribute so we have to copy object
183185
for _item in copy(language_menu.items):

tests/requirements/compile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def run(*args, **kwargs):
6969
"-m",
7070
"piptools",
7171
"compile",
72-
"--generate-hashes",
72+
# temporarily remove "--generate-hashes", until all dependencies are actual releases
7373
"--allow-unsafe",
7474
] + sys.argv[1:]
7575

tests/requirements/djmain-py310-default.txt

Lines changed: 0 additions & 167 deletions
This file was deleted.

0 commit comments

Comments
 (0)