fix: Admin complained about missing methods get_author and get_modified_date (#307)

* fix: Admin complained about missing methods get_author and get_modified_date

* chore: Add types

* fix: Do not imply correlation of get_author and get_modified_state

Author: fsbraun

djangocms_alias/admin.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+from collections.abc import Iterable
+
 from cms.admin.utils import GrouperModelAdmin
 from cms.utils.permissions import get_model_permission_codename
 from cms.utils.urlutils import admin_reverse
@@ -16,7 +18,6 @@
 from django.utils.translation import gettext_lazy as _
 from parler.admin import TranslatableAdmin
 
-from .cms_config import AliasCMSConfig
 from .constants import (
     CHANGE_ALIAS_URL_NAME,
     DELETE_ALIAS_URL_NAME,
@@ -37,13 +38,6 @@
     "AliasContentAdmin",
 ]
 
-alias_admin_list_display = ["content__name", "category", "static", "used", "admin_list_actions"]
-djangocms_versioning_enabled = AliasCMSConfig.djangocms_versioning_enabled
-
-if djangocms_versioning_enabled:
-    alias_admin_list_display.insert(-1, "get_author")
-    alias_admin_list_display.insert(-1, "get_modified_date")
-
 
 @admin.register(Category)
 class CategoryAdmin(TranslatableAdmin):
@@ -64,7 +58,7 @@ def save_model(self, request, obj, form, change):
 
 @admin.register(Alias)
 class AliasAdmin(GrouperModelAdmin):
-    list_display = alias_admin_list_display
+    list_display = ["content__name", "category", "static", "used", "admin_list_actions"]
     list_display_links = None
     list_filter = (
         SiteFilter,
@@ -82,11 +76,20 @@ def get_actions_list(self) -> list:
         """Add alias usage list actions"""
         return super().get_actions_list() + [self._get_alias_usage_link, self._get_alias_delete_link]
 
-    def get_queryset(self, request):
+    def get_queryset(self, request: HttpRequest) -> models.QuerySet:
         qs = super().get_queryset(request)
         # Annotate each Alias with a boolean indicating if related cmsplugins exist
         return qs.annotate(cmsplugins_count=models.Count("cms_plugins"))
 
+    def get_list_display(self, request: HttpRequest) -> Iterable[str]:
+        list_display = super().get_list_display(request)
+        list_display = list(list_display)
+        if hasattr(self, "get_author"):
+            list_display.insert(-1, "get_author")
+        if hasattr(self, "get_modified_date"):
+            list_display.insert(-1, "get_modified_date")
+        return list_display
+
     @admin.display(description=_("Used"), boolean=True, ordering="cmsplugins_count")
     def used(self, obj: Alias) -> bool | None:
         if obj.static_code and obj.cmsplugins_count == 0: