Skip to content

Commit 815c6e5

Browse files
committed
Fix tests
1 parent af9c038 commit 815c6e5

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

tests/test_toolbar.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import itertools
22
from collections import ChainMap
3-
from unittest import skipUnless
43

54
from cms.cms_toolbars import (
65
ADMIN_MENU_IDENTIFIER,
@@ -319,7 +318,6 @@ def test_create_wizard_button_enabled(self):
319318
create_button = self._get_wizard_create_button(request)
320319
self.assertEqual(create_button.disabled, False)
321320

322-
@skipUnless(not is_versioning_enabled(), "Test only relevant when no versioning")
323321
def test_delete_button_show_on_edit_alias_view_no_versioning(self):
324322
"""
325323
When versioning is not installed deletion should be possible. The delete button
@@ -347,25 +345,6 @@ def test_delete_button_show_on_edit_alias_view_no_versioning(self):
347345
self.get_list_alias_endpoint(),
348346
)
349347

350-
@skipUnless(is_versioning_enabled(), "Test only relevant for versioning")
351-
def test_delete_button_not_shown_on_edit_alias_view_with_versioning(self):
352-
"""
353-
When versioning is installed no deletion should be possible. The delete button
354-
should not be available in the toolbar.
355-
"""
356-
alias = self._create_alias()
357-
request = self.get_alias_request(
358-
alias=alias,
359-
user=self.superuser,
360-
edit=True,
361-
)
362-
button_label = "Delete alias..."
363-
alias_menu = request.toolbar.get_menu(ALIAS_MENU_IDENTIFIER)
364-
search_result = alias_menu.find_first(item_type=ModalItem, name=button_label)
365-
366-
# No button should be found for delete
367-
self.assertIsNone(search_result)
368-
369348
def test_do_not_disable_buttons_when_in_preview_mode(self):
370349
alias = self._create_alias()
371350
request = self.get_alias_request(

tests/test_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -958,7 +958,7 @@ def test_delete_alias_view_get_alias_not_used_on_any_page(self):
958958
args=[alias.pk],
959959
),
960960
)
961-
self.assertContains(response, "This alias wasn't used by any object.")
961+
self.assertContains(response, "This alias is not used by any object.")
962962

963963
def test_delete_alias_view_post(self):
964964
"""Tests the admin delete view (as opposed to the djangocms_alias.views.delete_view)"""

0 commit comments

Comments
 (0)