Skip to content

Commit 87e6a66

Browse files
committed
fix: filter Break objects and update expected language menu items
Filter out Break objects when checking language menu items since they don't have a name attribute. Also update the expected result when versioning is enabled to include 'Add Translation' which is now part of the menu with the new django-fsm-2 and versioning integration.
1 parent ddf2c1e commit 87e6a66

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/test_toolbar.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ def test_language_switcher_when_toolbar_object_is_alias_content(self):
218218
)
219219
language_menu = request.toolbar.get_menu(LANGUAGE_MENU_IDENTIFIER)
220220

221-
self.assertEqual([item.name for item in language_menu.items], expected_result)
221+
self.assertEqual([item.name for item in language_menu.items if not isinstance(item, Break)], expected_result)
222222

223223
def test_language_switcher_when_toolbar_object_isnt_alias_content(self):
224224
request = self.get_page_request(
@@ -231,10 +231,10 @@ def test_language_switcher_when_toolbar_object_isnt_alias_content(self):
231231
# Versioning changes the toolbar language selector and only shows
232232
# languages that have translations
233233
if is_versioning_enabled():
234-
expected_result = ["English"]
234+
expected_result = ["English", "Add Translation"]
235235

236236
# Don't change default language switcher that is used for Pages
237-
self.assertEqual([item.name for item in language_menu.items], expected_result)
237+
self.assertEqual([item.name for item in language_menu.items if not isinstance(item, Break)], expected_result)
238238

239239
def test_page_toolbar_no_language_menu(self):
240240
from django.utils.translation import gettext as _

0 commit comments

Comments
 (0)