Update tests

Author: fsbraun

.gitignore

@@ -15,3 +15,4 @@ htmlcov
 venv*
 node_modules
 .editorconfig
+.vscode/

djangocms_alias/cms_plugins.py

@@ -276,7 +276,6 @@ def detach_alias_plugin_view(self, request, plugin_pk):
         language = get_language_from_request(request)
 
         plugins = instance.alias.get_plugins(language, show_draft_content=True)
-        print(plugins)
         can_detach = self.can_detach(request.user, instance.placeholder, plugins)
 
         if not can_detach:

tests/test_models.py

@@ -2,6 +2,7 @@
 from cms.models import Placeholder
 from django.contrib.sites.models import Site
 from django.core.exceptions import ValidationError
+from django.db.models import ProtectedError
 from django.urls import reverse
 
 from djangocms_alias.cms_plugins import Alias
@@ -383,21 +384,24 @@ def test_pages_and_aliases_using_objects(self):
         )
 
     def test_delete(self):
+        """Deleting an Alias MUST NOT delete plugins."""
         self.page.delete()
 
         alias = self._create_alias([self.plugin])
-        add_plugin(
+        plugin = add_plugin(
             self.placeholder,
             Alias,
             language=self.language,
             alias=alias,
         )
         self.assertEqual(Placeholder.objects.count(), 1)
-        alias.delete()
-        self.assertFalse(alias.__class__.objects.filter(pk=alias.pk).exists())
-        self.assertEqual(Placeholder.objects.count(), 0)
+        with self.assertRaises(ProtectedError):
+            alias.delete()
+        self.assertTrue(alias.__class__.objects.filter(pk=alias.pk).exists())
+        self.assertEqual(Placeholder.objects.count(), 1)
         alias.save()  # Django 4.1+ disallows to use relations (cmsplugins) of unsaved objects.
-        self.assertEqual(alias.cms_plugins.count(), 0)
+        self.assertEqual(alias.cms_plugins.count(), 1)
+        plugin.placeholder.delete_plugin(plugin)
 
     def test_category_get_admin_change_url(self):
         """

tests/test_views.py

@@ -908,6 +908,20 @@ def test_alias_usage_view(self):
         )
 
     def test_delete_alias_view_get(self):
+        alias = self._create_alias([self.plugin])
+        with self.login_user_context(self.superuser):
+            response = self.client.get(
+                admin_reverse(
+                    DELETE_ALIAS_URL_NAME,
+                    args=[alias.pk],
+                ),
+            )
+        self.assertContains(
+            response,
+            f'Are you sure you want to delete the alias "{alias.name}"?',  # noqa: E501
+        )
+
+    def test_delete_alias_view_get_protected(self):
         alias = self._create_alias([self.plugin])
         add_plugin(
             self.placeholder,
@@ -922,13 +936,13 @@ def test_delete_alias_view_get(self):
                     args=[alias.pk],
                 ),
             )
-        self.assertContains(
-            response,
-            f'Are you sure you want to delete the alias "{alias.name}"?',  # noqa: E501
-        )
+
+        self.assertContains(response, "Cannot delete alias")
+        self.assertContains(response, "This alias is used by following objects")
 
     def test_delete_alias_view_get_using_objects(self):
         alias = self._create_alias([self.plugin])
+
         add_plugin(
             self.placeholder,
             "Alias",