Skip to content

Commit ea5a5e0

Browse files
committed
added changes
1 parent ac7cf7f commit ea5a5e0

File tree

7 files changed

+34
-9
lines changed

7 files changed

+34
-9
lines changed

CHANGELOG.rst

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@ Changelog
66
2.0.0 (unreleased)
77
==================
88

9-
* ...
9+
* Added tests
10+
* Cleaned up file structure
11+
* Removed Django < 1.8 support
12+
* Adapted ``README.txt``
1013

1114

1215
1.0.0 (2016-03-04)

djangocms_file/migrations/0002_auto_20151202_1551.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class Migration(migrations.Migration):
2020
migrations.AlterField(
2121
model_name='file',
2222
name='target',
23-
field=models.CharField(default=b'', choices=[(b'', 'same window'), (b'_blank', 'new window'), (b'_parent', 'parent window'), (b'_top', 'topmost frame')], max_length=100, blank=True, help_text='Optional link target.', verbose_name='target'),
23+
field=models.CharField(default='', choices=[('', 'same window'), ('_blank', 'new window'), ('_parent', 'parent window'), ('_top', 'topmost frame')], max_length=100, blank=True, help_text='Optional link target.', verbose_name='target'),
2424
preserve_default=True,
2525
),
2626
migrations.AlterField(

djangocms_file/migrations/0007_adapted_fields.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class Migration(migrations.Migration):
2222
migrations.AddField(
2323
model_name='file',
2424
name='template',
25-
field=models.CharField(default=b'default', max_length=255, verbose_name='Template', choices=[(b'default', 'Default')]),
25+
field=models.CharField(default='default', max_length=255, verbose_name='Template', choices=[('default', 'Default')]),
2626
),
2727
migrations.RenameField(
2828
model_name='file',

djangocms_file/migrations/0008_add_folder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ class Migration(migrations.Migration):
1919
migrations.CreateModel(
2020
name='Folder',
2121
fields=[
22-
('template', models.CharField(default=b'default', max_length=255, verbose_name='Template', choices=[(b'default', 'Default')])),
23-
('link_target', models.CharField(default=b'', max_length=255, verbose_name='Link target', blank=True, choices=[(b'_self', 'Open in same window.'), (b'_blank', 'Open in new window.'), (b'_parent', 'Delegate to parent.'), (b'_top', 'Delegate to top.')])),
22+
('template', models.CharField(default='default', max_length=255, verbose_name='Template', choices=[('default', 'Default')])),
23+
('link_target', models.CharField(default='', max_length=255, verbose_name='Link target', blank=True, choices=[('_self', 'Open in same window.'), ('_blank', 'Open in new window.'), ('_parent', 'Delegate to parent.'), ('_top', 'Delegate to top.')])),
2424
('show_file_size', models.BooleanField(default=False, help_text='Appends the file size at the end of the name.', verbose_name='Show file size')),
2525
('attributes', djangocms_attributes_field.fields.AttributesField(default=dict, verbose_name='Attributes', blank=True)),
2626
('cmsplugin_ptr', models.OneToOneField(parent_link=True, related_name='djangocms_file_folder', primary_key=True, serialize=False, to='cms.CMSPlugin')),

djangocms_file/models.py

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ class File(CMSPlugin):
4040
Renders a file wrapped by an anchor
4141
"""
4242
search_fields = ('name',)
43+
4344
TEMPLATE_CHOICES = [
4445
('default', _('Default')),
4546
]
@@ -84,7 +85,7 @@ class File(CMSPlugin):
8485
attributes = AttributesField(
8586
verbose_name=_('Attributes'),
8687
blank=True,
87-
excluded_keys=['title', 'target'],
88+
excluded_keys=['href', 'title', 'target'],
8889
)
8990

9091
# Add an app namespace to related_name to avoid field name clashes
@@ -98,10 +99,20 @@ class File(CMSPlugin):
9899
)
99100

100101
def __str__(self):
102+
if self.file_src and self.file_src.label:
103+
return self.file_src.label
104+
return str(self.pk)
105+
106+
def get_short_description(self):
101107
if self.file_src and self.file_src.label:
102108
return self.file_src.label
103109
return ugettext('<file is missing>')
104110

111+
def copy_relations(self, oldinstance):
112+
# Because we have a ForeignKey, it's required to copy over
113+
# the reference from the instance to the new plugin.
114+
self.file_src = oldinstance.file_src
115+
105116

106117
@python_2_unicode_compatible
107118
class Folder(CMSPlugin):
@@ -141,7 +152,7 @@ class Folder(CMSPlugin):
141152
attributes = AttributesField(
142153
verbose_name=_('Attributes'),
143154
blank=True,
144-
excluded_keys=['target'],
155+
excluded_keys=['href', 'target'],
145156
)
146157

147158
# Add an app namespace to related_name to avoid field name clashes
@@ -155,10 +166,20 @@ class Folder(CMSPlugin):
155166
)
156167

157168
def __str__(self):
169+
if self.folder_src and self.folder_src.name:
170+
return self.folder_src.name
171+
return str(self.pk)
172+
173+
def get_short_description(self):
158174
if self.folder_src and self.folder_src.name:
159175
return self.folder_src.name
160176
return ugettext('<folder is missing>')
161177

178+
def copy_relations(self, oldinstance):
179+
# Because we have a ForeignKey, it's required to copy over
180+
# the reference from the instance to the new plugin.
181+
self.folder_src = oldinstance.folder_src
182+
162183
def get_files(self):
163184
folder_files = []
164185

djangocms_file/templates/djangocms_file/default/file.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
{% if instance.file_name %}
66
{{ instance.file_name }}
77
{% else %}
8-
{{ instance.file_src.name }}
8+
{{ instance.file_src.label }}
99
{% endif %}
1010
{% if instance.show_file_size %}
11-
<span>{{ intsance.file_src.size|filesizeformat }}</span>
11+
<span>{{ instance.file_src.size|filesizeformat }}</span>
1212
{% endif %}
1313
</a>
1414

djangocms_file/templates/djangocms_file/default/folder.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
<span>{{ file.size|filesizeformat }}</span>
1010
{% endif %}
1111
</a>
12+
{% if not forloop.last %}<br>{% endif %}
1213
{% empty %}
1314
<p>{% trans "No files were found in the specified folder." %}</p>
1415
{% endfor %}

0 commit comments

Comments
 (0)