chore: add tests for form rendering (#33)

* chore: add tests for form rendering

* fix tests for cms 3

* fix tests for cms 3

* add ajax tests

* chore: add action tests

* add action registry tests

* add helper tests

* fix tests for cms 3

* fix tests for cms 3

* add select plugin test

* add more model tests

* fix: delete plugin for v3

* add more action maps

Author: fsbraun

.github/workflows/codecov.yml

@@ -42,8 +42,6 @@ jobs:
     - name: Generate Report
       run: |
         coverage run ./run_tests.py
-    - name: Generate XML report
-      run: |
         coverage xml
     - name: Upload Coverage to Codecov
       uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7

.github/workflows/publish-to-live-pypi.yml

@@ -11,10 +11,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-    - name: Set up Python 3.10
+    - name: Set up Python 3.13
       uses: actions/setup-python@v5
       with:
-        python-version: '3.10'
+        python-version: '3.13'
 
     - name: Install pypa/build
       run: >-

.pre-commit-config.yaml

@@ -16,4 +16,5 @@ repos:
   rev: aad66557af3b56ba6d4d69cd1b6cba87cef50cbb  # frozen: v0.14.3
   hooks:
     - id: ruff
+      args: [ --fix ]
     - id: ruff-format

djangocms_form_builder/helpers.py

@@ -125,7 +125,10 @@ def add_plugin(placeholder, plugin):
 
 def delete_plugin(plugin):
     """CMS version save function to delete a plugin (and its descendants) from a placeholder"""
-    return plugin.placeholder.delete_plugin(plugin)
+    if hasattr(plugin.placeholder, "delete_plugin"):  # CMS v4?
+        return plugin.placeholder.delete_plugin(plugin)
+    else:  # CMS < v4
+        return plugin.delete()
 
 
 def coerce_decimal(value):

run_tests.py

@@ -12,7 +12,7 @@ def run():
     django.setup()
     TestRunner = get_runner(settings)
     test_runner = TestRunner()
-    failures = test_runner.run_tests(["tests"])
+    failures = test_runner.run_tests(sys.argv[1:] or ["tests"])
     sys.exit(bool(failures))
 
 

tests/requirements/base.txt

@@ -1,6 +1,7 @@
 django-filer
 easy-thumbnails
 djangocms-text
+djangocms-link
 coverage
 django-app-helper
 django-treebeard<4.5

tests/test_action_registry.py

@@ -0,0 +1,100 @@
+from django.core.exceptions import ImproperlyConfigured
+from django.test import SimpleTestCase
+
+from djangocms_form_builder import actions as actions_module
+from djangocms_form_builder.actions import FormAction
+
+
+class DummyAction(FormAction):
+    verbose_name = "Dummy action"
+
+    def execute(self, form, request):  # pragma: no cover - trivial
+        return None
+
+
+class NoVerboseAction(FormAction):
+    verbose_name = None
+
+    def execute(self, form, request):  # pragma: no cover - trivial
+        return None
+
+
+class NotAnAction:
+    pass
+
+
+class ActionRegistryTests(SimpleTestCase):
+    def setUp(self):
+        super().setUp()
+        # Backup the original registry so we can safely modify it
+        self._orig_registry = actions_module._action_registry.copy()
+
+    def tearDown(self):
+        # Restore the registry to its original state
+        actions_module._action_registry.clear()
+        actions_module._action_registry.update(self._orig_registry)
+        super().tearDown()
+
+    def test_register_adds_action_and_getters_work(self):
+        action_hash = actions_module.get_hash(DummyAction)
+        self.assertIsNone(actions_module.get_action_class(action_hash))
+
+        actions_module.register(DummyAction)
+
+        # get_action_class returns the class
+        self.assertIs(actions_module.get_action_class(action_hash), DummyAction)
+        # get_registered_actions contains our (hash, verbose_name) pair
+        choices = dict(actions_module.get_registered_actions())
+        self.assertIn(action_hash, choices)
+        self.assertEqual(choices[action_hash], DummyAction.verbose_name)
+
+    def test_unregister_removes_action(self):
+        action_hash = actions_module.get_hash(DummyAction)
+        actions_module.register(DummyAction)
+        self.assertIsNotNone(actions_module.get_action_class(action_hash))
+
+        actions_module.unregister(DummyAction)
+        self.assertIsNone(actions_module.get_action_class(action_hash))
+
+        choices = dict(actions_module.get_registered_actions())
+        self.assertNotIn(action_hash, choices)
+
+    def test_register_rejects_non_subclass(self):
+        with self.assertRaises(ImproperlyConfigured):
+            actions_module.register(NotAnAction)  # type: ignore[arg-type]
+
+    def test_register_rejects_missing_verbose_name(self):
+        with self.assertRaises(ImproperlyConfigured):
+            actions_module.register(NoVerboseAction)
+
+    def test_register_is_idempotent(self):
+        # capture current size
+        size_before = len(actions_module._action_registry)
+        actions_module.register(DummyAction)
+        size_after_first = len(actions_module._action_registry)
+        actions_module.register(DummyAction)
+        size_after_second = len(actions_module._action_registry)
+
+        self.assertEqual(size_after_first, size_before + 1)
+        self.assertEqual(size_after_second, size_after_first)
+
+        actions_module.unregister(DummyAction)
+        self.assertEqual(len(actions_module._action_registry), size_before)
+
+    def test_unregister_is_safe_when_absent(self):
+        size_before = len(actions_module._action_registry)
+        actions_module.unregister(DummyAction)  # should not raise
+        self.assertEqual(len(actions_module._action_registry), size_before)
+
+    def test_get_registered_actions_empty_fallback(self):
+        # Clear registry to simulate no actions registered
+        actions_module._action_registry.clear()
+        choices = actions_module.get_registered_actions()
+
+        # Expect a single-choice tuple with an empty options tuple
+        self.assertIsInstance(choices, tuple)
+        self.assertEqual(len(choices), 1)
+        self.assertIsInstance(choices[0], tuple)
+        self.assertEqual(len(choices[0]), 2)
+        self.assertIsInstance(choices[0][1], tuple)
+        self.assertEqual(choices[0][1], ())