perf: optimize submit button check to avoid extra DB query

earthcomfy · earthcomfy · commit e4ab77899dc7 · 2025-02-25T14:09:19.000+03:00
diff --git a/djangocms_form_builder/cms_plugins/ajax_plugins.py b/djangocms_form_builder/cms_plugins/ajax_plugins.py
@@ -241,7 +241,8 @@ def render(self, context, instance, placeholder):
         context.update(self.set_context(context, instance, placeholder))
         context["form_counter"] = context.get("form_counter", 0) + 1
         has_submit_button = any(
-            child.plugin_type == "SubmitPlugin" for child in instance.get_children()
+            child.plugin_type == "SubmitPlugin"
+            for child in (instance.child_plugin_instances)
         )
         context.update(
             {

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,8 @@ def render(self, context, instance, placeholder):`
`241`	`241`	`context.update(self.set_context(context, instance, placeholder))`
`242`	`242`	`context["form_counter"] = context.get("form_counter", 0) + 1`
`243`	`243`	`has_submit_button = any(`
`244`		`- child.plugin_type == "SubmitPlugin" for child in instance.get_children()`
	`244`	`+ child.plugin_type == "SubmitPlugin"`
	`245`	`+ for child in (instance.child_plugin_instances)`
`245`	`246`	`)`
`246`	`247`	`context.update(`
`247`	`248`	`{`