Keep checking for use_no_cropping flag, and test case to cover

Author: marbru

djangocms_frontend/contrib/image/models.py

@@ -120,8 +120,9 @@ def img_src(self):
         # in this case we want to return an empty string to avoid #69
         elif not self.picture:
             return ""
-        # skip image processing when there's no width or height defined
-        elif not self.width and not self.height:
+        # skip image processing when there's no width or height defined,
+        # or when legacy use_no_cropping flag is present
+        elif getattr(self, 'use_no_cropping', None) or not (self.width or self.height):
             return self.rel_image.url if self.rel_image else ""
 
         picture_options = self.get_size(

tests/image/test_plugins.py

@@ -103,6 +103,28 @@ def test_img_processing(self):
         self.assertEqual(response.status_code, 200)
         self.assertContains(response, '/test_file.jpg"')
 
+        # Original image also used if legacy use_no_cropping flag is present,
+        # even when there is widht and height
+        plugin = add_plugin(
+            placeholder=self.placeholder,
+            plugin_type=ImagePlugin.__name__,
+            language=self.language,
+            config={
+                "picture": {"pk": self.image.id, "model": "filer.Image"},
+                "width": 50,
+                "height": 100,
+                "use_no_cropping": True,
+            },
+        )
+        plugin.initialize_from_form(ImageForm)
+        plugin.save()
+        self.publish(self.page, self.language)
+
+        with self.login_user_context(self.superuser):
+            response = self.client.get(self.request_url)
+        self.assertEqual(response.status_code, 200)
+        self.assertContains(response, '/test_file.jpg"')
+
     def test_image_form(self):
         request = HttpRequest()
         request.POST = {