fix: make grid layout (rows/columns) compatible with flex box-based Django admin (#208)

Author: fsbraun

djangocms_frontend/contrib/link/helpers.py

@@ -10,6 +10,8 @@
 from django.utils.encoding import force_str
 from django.utils.html import mark_safe
 
+from djangocms_frontend.settings import EMPTY_CHOICE
+
 LINK_MODELS = getattr(django_settings, "DJANGOCMS_FRONTEND_LINK_MODELS", [])
 
 
@@ -66,7 +68,7 @@ def get_link_choices(request, term="", lang=None, nbsp=None):
 
     if nbsp is None:
         nbsp = "" if term else "\u2000"
-    available_objects = []
+    available_objects = [dict(id=EMPTY_CHOICE[0][0], text=EMPTY_CHOICE[0][1])]
     # Now create our list of cms pages
     type_id = ContentType.objects.get_for_model(Page).id
     for value, descr in get_page_choices(lang):

djangocms_frontend/contrib/utilities/frameworks/bootstrap5.py

@@ -6,7 +6,7 @@ def render(self, context, instance, placeholder):
             )
         else:
             instance.add_classes(
-                f"{instance.space_property}{instance.space_sides}-{ instance.space_device }-{instance.space_size}"
+                f"{instance.space_property}{instance.space_sides}-{instance.space_device}-{instance.space_size}"
             )
         return super().render(context, instance, placeholder)
 

djangocms_frontend/static/djangocms_frontend/css/base.css

@@ -30,6 +30,10 @@
     padding: 0;
     min-width: 800px;
 
+    > div > div:not([class]) {  // fix a quirk of djangocms-admin-style
+        width: unset  !important;
+        max-width: unset  !important;
+    }
     .field-box:first-child {
         width: 115px !important;
     }
@@ -39,6 +43,7 @@
         box-sizing: content-box;
         width: 86px !important;
         flex: none;
+        display: block;
         padding: 15px 10px;
         margin: 0 !important;
         border-bottom: 1px solid #eee;

private/sass/components/_grid-layout.scss

@@ -119,8 +119,8 @@ def test_plugin(self):
     def test_smart_link_field(self):
         slf = SmartLinkField()
         choices = get_choices(None)
-        self.assertEqual("example.com", choices[0][0])  # Site name
-        self.assertIn(("2-1", "home"), choices[0][1])
+        self.assertEqual("example.com", choices[1][0])  # Site name
+        self.assertIn(("2-1", "home"), choices[1][1])
 
         cleaned = slf.clean("2-1")
         self.assertEqual(dict(model="cms.page", pk=1), cleaned)