Better accessing to context request.

Author: zbohm

djangocms_frontend/templatetags/frontend.py

@@ -1,5 +1,6 @@
 import json
 import typing
+import uuid
 
 from classytags.arguments import Argument, MultiKeywordArgument
 from classytags.core import Options, Tag
@@ -11,6 +12,7 @@
 from django.contrib.contenttypes.models import ContentType
 from django.core.serializers.json import DjangoJSONEncoder
 from django.db import models
+from django.http import HttpRequest
 from django.template.defaultfilters import safe
 from django.utils.encoding import force_str
 from django.utils.functional import Promise
@@ -77,11 +79,14 @@ def get_attributes(attribute_field, *add_classes):
 @register.simple_tag(takes_context=True)
 def set_html_id(context: template.Context, instance: FrontendUIItem) -> str:
     if instance.html_id is None:
-        request = context["request"]
-        key = "frontend_plugins_counter"
-        counter = getattr(request, key, 0) + 1
-        instance.html_id = f"frontend-plugins-{counter}"
-        setattr(request, key, counter)
+        request = context.get("request")
+        if isinstance(request, HttpRequest):
+            key = "frontend_plugins_counter"
+            counter = getattr(request, key, 0) + 1
+            instance.html_id = f"frontend-plugins-{counter}"
+            setattr(request, key, counter)
+        else:
+            instance.html_id = f"uuid4={uuid.uuid4()}"
     return instance.html_id
 
 

tests/collapse/test_plugins.py

@@ -1,5 +1,8 @@
+from unittest.mock import patch
+
 from cms.api import add_plugin
 from cms.test_utils.testcases import CMSTestCase
+from django.template import Context
 
 from djangocms_frontend.contrib.collapse.cms_plugins import (
     CollapseContainerPlugin,
@@ -11,6 +14,8 @@
     CollapseForm,
     CollapseTriggerForm,
 )
+from djangocms_frontend.models import FrontendUIItem
+from djangocms_frontend.templatetags.frontend import set_html_id
 
 from ..fixtures import TestFixture
 
@@ -99,3 +104,12 @@ def create_plugin():
             response,
             """<div id="collapse-frontend-plugins-2" data-bs-children=".card" role="tablist"></div>""",
             html=True)
+
+    def test_set_html_id(self):
+        instance = FrontendUIItem()
+        context = Context()
+        with patch("os.urandom", lambda n: b'\x1bB\x96\xabyI\xf6`\xd0\xc0,\xf8\x83\xe8,\xb8'):
+            html_id = set_html_id(context, instance)
+        identifier = "uuid4=1b4296ab-7949-4660-90c0-2cf883e82cb8"
+        self.assertEqual(html_id, identifier)
+        self.assertEqual(instance.html_id, identifier)