Remove "Use original image" (use_no_cropping) option from image plugin, and purge ocurrences

Author: marbru

djangocms_frontend/contrib/image/cms_plugins.py

@@ -75,7 +75,6 @@ class ImagePlugin(
             {
                 "classes": ("collapse",),
                 "fields": (
-                    ("use_no_cropping"),
                     ("use_crop", "use_upscale"),
                     "thumbnail_options",
                 ),

djangocms_frontend/contrib/image/forms.py

@@ -75,7 +75,6 @@ class Meta:
                 "alignment",
                 "link_attributes",
                 "use_crop",
-                "use_no_cropping",
                 "use_upscale",
                 "use_responsive_image",
                 "thumbnail_options",
@@ -139,13 +138,6 @@ class Meta:
         help_text=_("Attributes apply to the <b>link</b>."),
     )
 
-    # ignores all other cropping options
-    # throws validation error if other cropping options are selected
-    use_no_cropping = forms.BooleanField(
-        label=_("Use original image"),
-        required=False,
-        help_text=_("Outputs the raw image without cropping."),
-    )
     # upscale and crop work together
     # throws validation error if other cropping options are selected
     use_crop = forms.BooleanField(
@@ -207,9 +199,6 @@ def clean(self):
         # certain cropping options do not work together, the following
         # list defines the disallowed options used in the ``clean`` method
         invalid_option_pairs = [
-            ("use_no_cropping", "use_crop"),
-            ("use_no_cropping", "use_upscale"),
-            ("use_no_cropping", "thumbnail_options"),
             ("thumbnail_options", "use_crop"),
             ("thumbnail_options", "use_upscale"),
         ]

djangocms_frontend/contrib/image/image_save.py

@@ -29,7 +29,7 @@ def create_image_plugin(filename, file, parent_plugin, **kwargs):
     img.config.update(
         {
             "picture": {"pk": image_obj.pk, "model": "filer.image"},
-            "use_no_cropping": True,
+            "use_no_cropping": True, # ask
         }
     )
     add_plugin(parent_plugin.placeholder, img)

djangocms_frontend/contrib/image/models.py

@@ -120,9 +120,6 @@ def img_src(self):
         # in this case we want to return an empty string to avoid #69
         elif not self.picture:
             return ""
-        # return the original, unmodified image
-        elif self.use_no_cropping:
-            return self.rel_image.url if self.rel_image else ""
 
         picture_options = self.get_size(
             width=self.width or 0,