Remove component link mixin

Author: fsbraun

docs/source/custom_components.rst

@@ -45,6 +45,8 @@ Add a ``cms_components.py`` file to the ``theme`` app:
 .. code-block:: python
 
     # theme/cms_components.py
+    from djangocms_link.fields import LinkFormField
+
     from djangocms_frontend.contrib.component.components import ComponentLinkMixin, CMSFrontendComponent
     from djangocms_frontend.contrib.component.components import components
     from djangocms_frontend.contrib.image.fields import ImageFormField
@@ -77,6 +79,7 @@ Add a ``cms_components.py`` file to the ``theme`` app:
             allow_children = False
 
         text = forms.CharField(required=True)
+        link = LinkFormField()
 
         def get_short_description(self):
             return self.text

tests/component/test_plugins.py

@@ -152,7 +152,8 @@ def test_simple_component_plugin(self):
         instance.config["link"] = {"internal_link": f"cms.page:{self.page.pk}"}
         instance.save()
 
-        link = instance.get_link()
+        from djangocms_link.templatetags.djangocms_link_tags import to_url
+        link = to_url(instance.link)
 
         self.publish(self.page, self.language)
 

tests/test_app/cms_components.py

@@ -1,9 +1,7 @@
 from django import forms
+from djangocms_link.fields import LinkFormField
 
-from djangocms_frontend.contrib.component.components import (
-    CMSFrontendComponent,
-    ComponentLinkMixin,
-)
+from djangocms_frontend.contrib.component.components import CMSFrontendComponent
 from djangocms_frontend.contrib.component.registry import components
 from djangocms_frontend.contrib.image.fields import ImageFormField
 
@@ -33,13 +31,14 @@ def get_short_description(self):
 
 
 @components.register
-class MyButton(ComponentLinkMixin, CMSFrontendComponent):
+class MyButton(CMSFrontendComponent):
     class Meta:
         name = "Button"
         render_template = "button.html"
         allow_children = False
 
     text = forms.CharField(required=True, initial="Click me")
+    link = LinkFormField()
 
     def get_short_description(self):
         return self.text

tests/test_app/templates/button.html

@@ -1 +1 @@
-<a class="btn" href="{{ instance.get_link }}">{{ instance.text }}</a>
+{% load djangocms_link_tags %}<a class="btn" href="{{ instance.link|to_url }}">{{ instance.text }}</a>