fix: make sure .delete() is also called when batch deleting in admin

Author: Marius Schulze

src/djangocms_snippet/admin.py

@@ -186,3 +186,12 @@ def has_delete_permission(self, request, obj=None):
                 get_model_permission_codename(self.model, "add"),
             )
         return False
+
+    def delete_queryset(self, request, queryset):
+        """
+        Override delete_queryset to ensure that the snippet grouper is deleted
+        when the last snippet in a group is deleted.
+        """
+        for obj in queryset:
+            obj.delete()
+        return queryset

tests/test_models.py

@@ -21,6 +21,23 @@ def setUp(self):
         self.snippet_grouper = self.snippet.snippet_grouper
         SnippetPluginFactory(snippet_grouper=self.snippet_grouper, language=["en"])
 
+    def test_snippet_grouper_stays_when_snippet_deleted(self):
+        """
+        Test that the snippet grouper stays when a snippet is deleted.
+        This is to ensure that the grouper is not deleted when there are
+        other snippets associated with it.
+        """
+        temp_snippet = Snippet.objects.create(
+            name="Temporary Snippet",
+            snippet_grouper=self.snippet_grouper,
+            html="<p>temporary</p>",
+            slug="temporary_snippet",
+        )
+        self.assertTrue(Snippet.admin_manager.filter(pk=self.snippet.pk).exists())
+        self.assertTrue(SnippetGrouper.objects.filter(pk=self.snippet_grouper.pk).exists())
+        temp_snippet.delete()
+        self.assertTrue(SnippetGrouper.objects.filter(pk=self.snippet_grouper.pk).exists())
+
     def test_snippet_grouper_deleted_with_last_snippet(self):
         grouper = SnippetGrouper.objects.create()
         snippet = Snippet.objects.create(