bug: Rich text editor initializes on empty-form when using StackedInline and leads to two RTE instances

[h-peters]

When using a StackedInline the Rich text editor also initializes in an empty-form. When the add-row button is clicked the Editor initializes again and is shown twice.

The selector for the form-row

djangocms-text/private/js/cms.editor.js

Line 23 in 13e87cd

this._inline_admin_selector = 'body.change-form .form-row';

in combination with the empty-form check

djangocms-text/private/js/cms.editor.js

Lines 47 to 50 in 13e87cd

	if (document.querySelector(this._inline_admin_selector + '.empty-form')) {
	// Marker for inline admin form: do **not** initialize empty form templates
	this._admin_selector = this._inline_admin_selector + ':not(.empty-form) ' + this._admin_selector;
	}

leads to not updating this._admin_selector

djangocms-text/private/js/cms.editor.js

Line 21 in 13e87cd

this._admin_selector = 'textarea.CMS_Editor';

The HTML for StackedInline does not match the selector body.change-form .form-row.empty-form
For TabularInline this works fine.

[fsbraun]

@h-peters Thanks for reporting this!

Looking at his, we probably need to add separate checks for stacked and tabular inline.

Tabular inline: .form-row.empty-form / .form-row:not(.empty-form)
Stacked inline: .inline-related.empty-form / .inline-related:not(.empty-form)

I probably not fully oversee this right now, but maybe the single selector could do the trick:

.form-row:not(.empty-form) textarea.CMS_Editor, .inline-related:not(.empty-form) textarea.CMS_Editor

Are you interested in creating a PR?