Skip to content

Commit 1de5ff5

Browse files
committed
fix: tests
1 parent 9dcdccb commit 1de5ff5

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

djangocms_versioning/admin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1101,7 +1101,7 @@ def publish_view(self, request, object_id):
11011101
# Redirect to published?
11021102
if not requested_redirect and conf.ON_PUBLISH_REDIRECT == "published":
11031103
if hasattr(version.content, "get_absolute_url"):
1104-
requested_redirect = get_object_live_url(version.content, site=get_current_site(request))
1104+
redirect_url = get_object_live_url(version.content, site=get_current_site(request)) or redirect_url
11051105

11061106
return self._internal_redirect(requested_redirect, redirect_url)
11071107

djangocms_versioning/test_utils/polls/models.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from cms.models import CMSPlugin
22
from django.db import models
33
from django.urls import reverse
4+
from django.utils.translation import override
45

56

67
class Poll(models.Model):
@@ -19,7 +20,8 @@ def __str__(self):
1920
return self.text
2021

2122
def get_absolute_url(self):
22-
return reverse("admin:polls_pollcontent_changelist")
23+
with override(self.language):
24+
return reverse("admin:polls_pollcontent_changelist")
2325

2426
def get_preview_url(self):
2527
return reverse("admin:polls_pollcontent_preview", args=[self.id])

tests/test_handlers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ def test_change_plugin(self):
4646
plugin = add_plugin(
4747
placeholder, "PollPlugin", version.content.language, poll=poll
4848
)
49-
plugin.page.get_absolute_url = lambda *args, **kwargs: "/test_page/" # Fake URL needed for URI
5049

5150
dt = datetime(2016, 6, 6)
5251
with freeze_time(dt):

tests/test_menus.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from cms import constants as cms_constants
22
from cms.test_utils.testcases import CMSTestCase
33
from cms.toolbar.toolbar import CMSToolbar
4-
from cms.toolbar.utils import get_object_preview_url
4+
from cms.toolbar.utils import get_object_edit_url, get_object_preview_url
55
from django.contrib.auth.models import AnonymousUser
66
from django.template import Context, Template
77
from django.test import RequestFactory
@@ -74,7 +74,7 @@ def _assert_node(self, node, version, edit_or_preview=True):
7474
self.assertEqual(node.title, content.title)
7575

7676
if edit_or_preview:
77-
self.assertEqual(node.url, get_object_preview_url(content))
77+
self.assertIn(node.url, (get_object_preview_url(content), get_object_edit_url(content),))
7878
else:
7979
self.assertEqual(node.url, content.get_absolute_url())
8080

0 commit comments

Comments
 (0)