Skip to content

Commit 5133f5f

Browse files
Removed logging about the toolbar failing to serialize a value into JSON. (#2181)
1 parent a1ad2be commit 5133f5f

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

debug_toolbar/store.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import contextlib
22
import json
3-
import logging
43
from collections import defaultdict, deque
54
from collections.abc import Iterable
65
from typing import Any
@@ -13,15 +12,12 @@
1312
from debug_toolbar import settings as dt_settings
1413
from debug_toolbar.models import HistoryEntry
1514

16-
logger = logging.getLogger(__name__)
17-
1815

1916
class DebugToolbarJSONEncoder(DjangoJSONEncoder):
2017
def default(self, o):
2118
try:
2219
return super().default(o)
2320
except (TypeError, ValueError):
24-
logger.debug("The debug toolbar can't serialize %s into JSON" % o)
2521
return force_str(o)
2622

2723

docs/changes.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Pending
55
-------
66

77
* Added a note about the default password in ``make example``.
8+
* Removed logging about the toolbar failing to serialize a value into JSON.
89

910
6.0.0 (2025-07-22)
1011
------------------

tests/test_store.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ def test_serialize(self):
1414
'{"hello": {"foo": "bar"}}',
1515
)
1616

17+
def test_serialize_logs_on_failure(self):
18+
self.assertEqual(
19+
store.serialize({"hello": {"foo": b"bar"}}),
20+
'{"hello": {"foo": "bar"}}',
21+
)
22+
1723
def test_deserialize(self):
1824
self.assertEqual(
1925
store.deserialize('{"hello": {"foo": "bar"}}'),

0 commit comments

Comments
 (0)