Skip to content

Commit edd9d82

Browse files
committed
Removed unneeded Panel.slug attribute.
1 parent 6b0d32f commit edd9d82

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

debug_toolbar/panels/__init__.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ class Panel(object):
2525
def __init__(self, toolbar, context={}):
2626
self.toolbar = toolbar
2727
self.context.update(context)
28-
self.slug = slugify(self.name)
2928

3029
def content(self):
3130
if self.has_content:
@@ -69,17 +68,13 @@ def enable_instrumentation(self):
6968
def disable_instrumentation(self):
7069
pass
7170

72-
# Store and retrieve stats (shared between panels)
71+
# Store and retrieve stats (shared between panels for no good reason)
7372

7473
def record_stats(self, stats):
75-
panel_stats = self.toolbar.stats.get(self.slug)
76-
if panel_stats:
77-
panel_stats.update(stats)
78-
else:
79-
self.toolbar.stats[self.slug] = stats
74+
self.toolbar.stats.setdefault(self.panel_id, {}).update(stats)
8075

8176
def get_stats(self):
82-
return self.toolbar.stats.get(self.slug, {})
77+
return self.toolbar.stats.get(self.panel_id, {})
8378

8479
# Standard middleware methods
8580

tests/test_integration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def _resolve_stats(self, path):
4545
panel = self.toolbar.get_panel_by_id('RequestPanel')
4646
panel.process_request(self.request)
4747
panel.process_response(self.request, self.response)
48-
return self.toolbar.stats['request']
48+
return panel.get_stats()
4949

5050
def test_url_resolving_positional(self):
5151
stats = self._resolve_stats('/resolving1/a/b/')

0 commit comments

Comments
 (0)