test has_changed on model form, test against 5.2rc1

Author: bckohan

.github/workflows/test.yml

@@ -36,7 +36,7 @@ jobs:
           - '3.2' # LTS April 2024
           - '4.2' # LTS April 2026
           - '5.1' # December 2025
-          - '5.2b1'
+          - '5.2rc1'
         exclude:
           - django-version: '4.2'
             postgres-version: '9.6'
@@ -58,15 +58,15 @@ jobs:
             django-version: '5.1'
 
           - postgres-version: '9.6'
-            django-version: '5.2b1'
+            django-version: '5.2rc1'
 
           - postgres-version: '12'
-            django-version: '5.2b1'
+            django-version: '5.2rc1'
 
           - python-version: '3.9'
             django-version: '5.1'
           - python-version: '3.9'
-            django-version: '5.2b1'
+            django-version: '5.2rc1'
           - python-version: '3.13'
             django-version: '3.2'
           - python-version: '3.13'
@@ -122,7 +122,7 @@ jobs:
     - name: Install Release Dependencies
       run: |
         just setup ${{ steps.sp.outputs.python-path }}
-        if [ "${{ matrix.django-version }}" = "5.2b1" ]; then
+        if [ "${{ matrix.django-version }}" = "5.2rc1" ]; then
           just test-lock "Django==${{ matrix.django-version }}"
         else
           just test-lock "Django~=${{ matrix.django-version }}.0"

src/django_enum/forms.py

@@ -424,8 +424,15 @@ class EnumMultipleChoiceField(  # type: ignore
     non_strict_widget = NonStrictSelectMultiple
 
     def has_changed(self, initial, data):
-        # TODO
-        return super().has_changed(initial, data)
+        return super().has_changed(
+            *(
+                [
+                    (str(en.value) if isinstance(en, Enum) else en)
+                    for en in initial or []
+                ],
+                [(str(en.value) if isinstance(en, Enum) else en) for en in data or []],
+            )
+        )
 
 
 class EnumFlagField(ChoiceFieldMixin, TypedMultipleChoiceField):  # type: ignore

tests/test_forms.py

@@ -645,3 +645,59 @@ def test_non_strict_field(self):
                 self.enum_primitive("non_strict_int"),
             )
         self.assertEqual(form["non_strict_int"].value(), [200, 203])
+
+    def test_has_changed(self):
+        {
+            "small_pos_int": [0],
+            "small_int": [self.SmallIntEnum.VAL2, self.SmallIntEnum.VALn1],
+            "pos_int": [2147483647, self.PosIntEnum.VAL3],
+            "int": [self.IntEnum.VALn1],
+            "big_pos_int": [2, self.BigPosIntEnum.VAL3],
+            "big_int": [self.BigIntEnum.VAL0],
+            "constant": [2.71828, self.Constants.GOLDEN_RATIO],
+            "text": [self.TextEnum.VALUE3, self.TextEnum.VALUE2],
+            "extern": [self.ExternEnum.THREE],
+            "date_enum": [self.DateEnum.BRIAN, date(1989, 7, 27)],
+            "datetime_enum": [self.DateTimeEnum.ST_HELENS, self.DateTimeEnum.ST_HELENS],
+            "duration_enum": [self.DurationEnum.FORTNIGHT],
+            "time_enum": [self.TimeEnum.COB, self.TimeEnum.LUNCH],
+            "decimal_enum": [self.DecimalEnum.ONE],
+            "non_strict_int": [self.SmallPosIntEnum.VAL2],
+            "non_strict_text": ["arbitrary", "A" * 13],
+            "no_coerce": [self.SmallPosIntEnum.VAL1],
+        }
+        form = self.FORM_CLASS(
+            data={"small_pos_int": [self.SmallPosIntEnum.VAL1]},
+            initial={"small_pos_int": [0]},
+        )
+        self.assertFalse(form.has_changed())
+
+        form = self.FORM_CLASS(
+            data={"small_pos_int": [self.SmallPosIntEnum.VAL2]},
+            initial={"small_pos_int": [0]},
+        )
+        self.assertTrue(form.has_changed())
+
+        form = self.FORM_CLASS(
+            data={"small_pos_int": [self.SmallPosIntEnum.VAL1.value]},
+            initial={"small_pos_int": [self.SmallPosIntEnum.VAL1]},
+        )
+        self.assertFalse(form.has_changed())
+
+        form = self.FORM_CLASS(
+            data={"small_pos_int": [self.SmallPosIntEnum.VAL2.value]},
+            initial={"small_pos_int": [self.SmallPosIntEnum.VAL1]},
+        )
+        self.assertTrue(form.has_changed())
+
+        form = self.FORM_CLASS(
+            data={"small_pos_int": [str(self.SmallPosIntEnum.VAL1.value)]},
+            initial={"small_pos_int": [self.SmallPosIntEnum.VAL1]},
+        )
+        self.assertFalse(form.has_changed())
+
+        form = self.FORM_CLASS(
+            data={"small_pos_int": [str(self.SmallPosIntEnum.VAL2.value)]},
+            initial={"small_pos_int": [self.SmallPosIntEnum.VAL1]},
+        )
+        self.assertTrue(form.has_changed())