fix static analysis issues

Author: bckohan

django_enum/drf.py

@@ -168,7 +168,7 @@ def to_internal_value(self, data: Any) -> Union[Enum, Any]:
                             return self.primitive_field.to_internal_value(data)
             return data
 
-        def to_representation(  # pylint: disable=R0201
+        def to_representation(
             self, value: Any
         ) -> Any:
             """

django_enum/fields.py

@@ -45,7 +45,7 @@
     NonStrictSelect,
     NonStrictSelectMultiple,
 )
-from django_enum.query import (  # HasAllFlagsExtraBigLookup,; HasAnyFlagsExtraBigLookup
+from django_enum.query import (  # HasAllFlagsExtraBigLookup,
     HasAllFlagsLookup,
     HasAnyFlagsLookup,
 )
@@ -807,10 +807,10 @@ def __init__(
         if self.enum:
             kwargs.setdefault(
                 'max_length',
-                max([
+                max((
                     len(self._coerce_to_value_type(choice[0]) or '')
                     for choice in kwargs.get('choices', choices(enum))
-                ])
+                ))
             )
         super().__init__(enum=enum, primitive=primitive, **kwargs)
 

django_enum/forms.py

@@ -310,7 +310,7 @@ def __init__(
             *,
             empty_value: Any = _Unspecified,
             strict: bool = ChoiceFieldMixin._strict_,
-            empty_values: List[Any] = TypedChoiceField.empty_values,
+            empty_values: Union[List[Any], Type[_Unspecified]] = _Unspecified,
             choices: Iterable[Tuple[Any, str]] = (),
             **kwargs
     ):

django_enum/query.py

@@ -50,14 +50,19 @@ def get_rhs_op(self, connection, rhs):
 #     HasAllFlagsLookup
 # ):  # pylint: disable=W0223
 #     """
-#     Support for bitwise has_all lookup on extra big integers (>64 bits) stored
-#     as binary columns.
+#     Support for bitwise has_all lookup on extra big integers (>64 bits)
+#     stored as binary columns.
 #
 #     get_bit(, 0) AND get_bit(, 7) = 1;
 #     """
 #
 #     def process_lhs(self, compiler, connection, lhs=None):
-#         lhs_sql, lhs_params = Exact.process_lhs(self, compiler, connection, lhs)
+#         lhs_sql, lhs_params = Exact.process_lhs(
+#               self,
+#               compiler,
+#               connection,
+#               lhs
+#         )
 #         rhs_sql, rhs_params = Exact.process_rhs(self, compiler, connection)
 #         bits = get_set_bits(rhs_params[0])
 #         if self.rhs:
@@ -97,12 +102,17 @@ def get_rhs_op(self, connection, rhs):
 #     HasAnyFlagsLookup
 # ):  # pylint: disable=W0223
 #     """
-#     Support for bitwise has_any lookup on extra big integers (>64 bits) stored
-#     as binary columns.
+#     Support for bitwise has_any lookup on extra big integers (>64 bits)
+#     stored as binary columns.
 #     """
 #
 #     def process_lhs(self, compiler, connection, lhs=None):
-#         lhs_sql, lhs_params = Exact.process_lhs(self, compiler, connection, lhs)
+#         lhs_sql, lhs_params = Exact.process_lhs(
+#               self,
+#               compiler,
+#               connection,
+#               lhs
+#         )
 #         rhs_sql, rhs_params = Exact.process_rhs(self, compiler, connection)
 #         bits = get_set_bits(rhs_params[0])
 #         if self.rhs:

django_enum/tests/benchmarks.py

@@ -9,7 +9,7 @@
 
 from django.db import connection
 from django.db.models import Q
-from django.test import TestCase, override_settings, SimpleTestCase
+from django.test import SimpleTestCase, TestCase, override_settings
 from django.test.utils import CaptureQueriesContext
 from django_enum.tests.benchmark import enums as benchmark_enums
 from django_enum.tests.benchmark import models as benchmark_models

django_enum/tests/djenum/migrations/0001_initial.py

@@ -1,11 +1,12 @@
 # Generated by Django 4.2.4 on 2023-10-02 16:10
 
 import datetime
+import pathlib
 from decimal import Decimal
-from django.db import migrations, models
+
 import django_enum.fields
 import django_enum.tests.djenum.enums
-import pathlib
+from django.db import migrations, models
 
 
 class Migration(migrations.Migration):

django_enum/tests/enum_prop/admin.py

@@ -1,6 +1,10 @@
 try:
     from django.contrib import admin
-    from django_enum.tests.enum_prop.models import BitFieldModel, AdminDisplayBug35, EnumTester
+    from django_enum.tests.enum_prop.models import (
+        AdminDisplayBug35,
+        BitFieldModel,
+        EnumTester,
+    )
 
     class AdminDisplayBug35Admin(admin.ModelAdmin):
 

django_enum/tests/enum_prop/migrations/0001_initial.py

@@ -2,8 +2,9 @@
 
 import datetime
 from decimal import Decimal
-from django.db import migrations, models
+
 import django_enum.fields
+from django.db import migrations, models
 
 
 class Migration(migrations.Migration):

django_enum/tests/tests.py

@@ -14,8 +14,8 @@
 from django.db.models import Count, F, Func, OuterRef, Q, Subquery
 from django.db.utils import DatabaseError
 from django.http import QueryDict
-from django.test.utils import CaptureQueriesContext
 from django.test import Client, LiveServerTestCase, TestCase
+from django.test.utils import CaptureQueriesContext
 from django.urls import reverse
 from django.utils.functional import classproperty
 from django_enum import EnumField, TextChoices
@@ -3034,10 +3034,10 @@ def test_unsupported_flags(self):
     )
     from django_enum.tests.enum_prop.forms import EnumTesterForm
     from django_enum.tests.enum_prop.models import (
+        AdminDisplayBug35,
         BitFieldModel,
         EnumFlagPropTester,
         EnumFlagPropTesterRelated,
-        AdminDisplayBug35,
         EnumTester,
         MyModel,
     )