Fix test flakyness (#100)

Author: pfouque

pyproject.toml

@@ -49,10 +49,12 @@ dev = [
     "coverage",
     "django-guardian",
     "graphviz",
+    "mypy",
     "pre-commit",
     "pytest",
     "pytest-cov",
     "pytest-django",
+    "pytest-randomly",
     "tox",
 ]
 

tests/testapp/tests/test_basic_transitions.py

@@ -138,6 +138,10 @@ def setUp(self):
         pre_transition.connect(self.on_pre_transition, sender=SimpleBlogPost)
         post_transition.connect(self.on_post_transition, sender=SimpleBlogPost)
 
+    def tearDown(self):
+        pre_transition.disconnect(self.on_pre_transition, sender=SimpleBlogPost)
+        post_transition.disconnect(self.on_post_transition, sender=SimpleBlogPost)
+
     def on_pre_transition(self, sender, instance, name, source, target, **kwargs):
         assert instance.state == source
         self.pre_transition_called = True
@@ -166,6 +170,10 @@ def setUp(self):
         pre_transition.connect(self.on_pre_transition, sender="testapp.SimpleBlogPost")
         post_transition.connect(self.on_post_transition, sender="testapp.SimpleBlogPost")
 
+    def tearDown(self):
+        pre_transition.disconnect(self.on_pre_transition, sender="testapp.SimpleBlogPost")
+        post_transition.disconnect(self.on_post_transition, sender="testapp.SimpleBlogPost")
+
 
 class TestFieldTransitionsInspect(TestCase):
     def setUp(self):

tests/testapp/tests/test_exception_transitions.py

@@ -28,6 +28,9 @@ def setUp(self):
         post_transition.connect(self.on_post_transition, sender=ExceptionalBlogPost)
         self.post_transition_data = {}
 
+    def tearDown(self):
+        post_transition.disconnect(self.on_post_transition, sender=ExceptionalBlogPost)
+
     def on_post_transition(self, **kwargs):
         self.post_transition_data = kwargs
 

tests/testapp/tests/test_multi_resultstate.py

@@ -49,6 +49,10 @@ def setUp(self):
         pre_transition.connect(self.on_pre_transition, sender=MultiResultTest)
         post_transition.connect(self.on_post_transition, sender=MultiResultTest)
 
+    def tearDown(self):
+        pre_transition.disconnect(self.on_pre_transition, sender=MultiResultTest)
+        post_transition.disconnect(self.on_post_transition, sender=MultiResultTest)
+
     def on_pre_transition(self, sender, instance, name, source, target, **kwargs):
         assert instance.state == source
         self.pre_transition_called = True