Merge pull request #183 from asherf/fix-tests

Fix flaky tests by adjusting bucket values.

Author: asherf

django_prometheus/tests/end2end/testapp/test_middleware.py

@@ -1,4 +1,4 @@
-from django.test import SimpleTestCase
+from django.test import SimpleTestCase, override_settings
 from django_prometheus.testutils import PrometheusTestCaseMixin
 from testapp.views import ObjectionException
 
@@ -19,6 +19,9 @@ def T(metric_name):
     return "%s_total" % M(metric_name)
 
 
+@override_settings(
+    PROMETHEUS_LATENCY_BUCKETS=(0.05, 1.0, 2.0, 4.0, 5.0, 10.0, float("inf"))
+)
 class TestMiddlewareMetrics(PrometheusTestCaseMixin, SimpleTestCase):
     """Test django_prometheus.middleware.
 
@@ -98,8 +101,8 @@ def test_request_counters(self):
     def test_latency_histograms(self):
         # Caution: this test is timing-based. This is not ideal. It
         # runs slowly (each request to /slow takes at least .1 seconds
-        # to complete) and it may be flaky when run on very slow
-        # systems.
+        # to complete), to eliminate flakiness we adjust the buckets used
+        # in the test suite.
 
         registry = self.saveRegistry()
 
@@ -134,7 +137,7 @@ def test_exception_latency_histograms(self):
             registry,
             2,
             M("requests_latency_seconds_by_view_method_bucket"),
-            le="0.05",
+            le="2.0",
             view="testapp.views.objection",
             method="GET",
         )