Skip to content

Commit 5c19481

Browse files
authored
Merge pull request #228 from asherf/tox
Use literals
2 parents 088e30c + 58686cc commit 5c19481

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

django_prometheus/middleware.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ def get_instance(cls):
3535
cls._instance = cls()
3636
return cls._instance
3737

38-
def register_metric(
39-
self, metric_cls, name, documentation, labelnames=tuple(), **kwargs
40-
):
38+
def register_metric(self, metric_cls, name, documentation, labelnames=(), **kwargs):
4139
return metric_cls(name, documentation, labelnames=labelnames, **kwargs)
4240

4341
def __init__(self, *args, **kwargs):

django_prometheus/tests/end2end/testapp/test_middleware_custom_labels.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@
1818

1919

2020
class CustomMetrics(Metrics):
21-
def register_metric(
22-
self, metric_cls, name, documentation, labelnames=tuple(), **kwargs
23-
):
21+
def register_metric(self, metric_cls, name, documentation, labelnames=(), **kwargs):
2422
if name in EXTENDED_METRICS:
2523
labelnames.extend(("view_type", "user_agent_type"))
2624
return super(CustomMetrics, self).register_metric(

django_prometheus/tests/end2end/testapp/test_migrations.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ def test_counters(self):
2626
executor = MagicMock()
2727
executor.migration_plan = MagicMock()
2828
executor.migration_plan.return_value = set()
29-
executor.loader.applied_migrations = set(["a", "b", "c"])
29+
executor.loader.applied_migrations = {"a", "b", "c"}
3030
ExportMigrationsForDatabase("fakedb1", executor)
3131
self.assertEqual(executor.migration_plan.call_count, 1)
3232
executor.migration_plan = MagicMock()
33-
executor.migration_plan.return_value = set(["a"])
34-
executor.loader.applied_migrations = set(["b", "c"])
33+
executor.migration_plan.return_value = {"a"}
34+
executor.loader.applied_migrations = {"b", "c"}
3535
ExportMigrationsForDatabase("fakedb2", executor)
3636

3737
self.assertMetricEquals(3, M("applied_total"), connection="fakedb1")

0 commit comments

Comments
 (0)